Skip to content
This repository was archived by the owner on Jul 18, 2023. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/configuration/config_options.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ namespace mtconnect {
DECLARE_CONFIGURATION(MqttCaCert);
DECLARE_CONFIGURATION(MqttCert);
DECLARE_CONFIGURATION(MqttPrivateKey);
DECLARE_CONFIGURATION(MqttClientId);
DECLARE_CONFIGURATION(MqttTls);
DECLARE_CONFIGURATION(MqttPort);
DECLARE_CONFIGURATION(MqttHost);
Expand Down
29 changes: 20 additions & 9 deletions src/mqtt/mqtt_client_impl.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,28 @@ namespace mtconnect {
url << "mqtt://" << m_host << ':' << m_port;
m_url = url.str();

std::stringstream identity;
identity << '_' << m_host << '_' << m_port;
// Some brokers require specific ClientID provided.
// If not specified in configuration then generate random one.
auto client_id = GetOption<string>(options, configuration::MqttClientId);
if (client_id) {
m_identity = *client_id;
}
else
{
std::stringstream identity;
identity << '_' << m_host << '_' << m_port;

boost::uuids::detail::sha1 sha1;
sha1.process_bytes(identity.str().c_str(), identity.str().length());
boost::uuids::detail::sha1::digest_type digest;
sha1.get_digest(digest);
boost::uuids::detail::sha1 sha1;
sha1.process_bytes(identity.str().c_str(), identity.str().length());
boost::uuids::detail::sha1::digest_type digest;
sha1.get_digest(digest);

identity.str("");
identity << std::hex << digest[0] << digest[1] << digest[2];
m_identity = std::string("_") + (identity.str()).substr(0, 10);
}

identity.str("");
identity << std::hex << digest[0] << digest[1] << digest[2];
m_identity = std::string("_") + (identity.str()).substr(0, 10);
LOG(debug) << "Using ClientID " << m_identity;

auto ci = GetOption<Seconds>(options, configuration::MqttConnectInterval);
if (ci)
Expand Down
3 changes: 2 additions & 1 deletion src/sink/mqtt_sink/mqtt_service.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ namespace mtconnect {
AddOptions(config, m_options,
{{configuration::MqttCaCert, string()},
{configuration::MqttPrivateKey, string()},
{configuration::MqttCert, string()}});
{configuration::MqttCert, string()},
{configuration::MqttClientId, string()}});
AddDefaultedOptions(config, m_options,
{{configuration::MqttHost, "127.0.0.1"s},
{configuration::DeviceTopic, "MTConnect/Device/"s},
Expand Down