chore: remove deprecated CaEdmontonProvider

[Copilot]

Removes all traces of the deprecated CaEdmontonProvider (etslive) from the commons repo.

Changes

• shared-modules/app-android/src/main/MTAndroidManifest.xml.MT.sh — deleted the CA_EDMONTON_PROVIDER_FILE conditional block that injected the CaEdmontonProvider <provider> entry into the generated AndroidManifest.xml
• shared/app-android/build.gradle — removed the ca_edmonton_authority / etslive resValue definition

Part of mtransitapps/commons-android#129.

Original prompt

Remove the deprecated CaEdmontonProvider from the codebase. Perform the following steps:

1. In shared-modules/app-android/src/main/MTAndroidManifest.xml.MT.sh:

   • Delete the section that checks for CA_EDMONTON_PROVIDER_FILE and the code that injects metadata for the Edmonton provider into the generated AndroidManifest.xml.
   • Remove the comment (and any other Edmonton-related comments in this file).

2. In shared/app-android/build.gradle:

   • Delete all lines that define gradle resource or authority for ca_edmonton_authority, or relate to etslive or Edmonton provider.
   • Remove all comments referring to CaEdmontonProvider, ca_edmonton, etslive, or Edmonton provider, if present.

3. Search the repository for any remaining comments, documentation, or code referencing CaEdmontonProvider, ca_edmonton, etslive, or Edmonton provider, and remove them.

4. Ensure no references to the removed provider remain (including in example configs or code).

Link this PR to mtransitapps/commons-android#129 ("Custom providers > delete deprecated/unused 🧹").

Testing: Confirm the repo builds and AndroidManifest.xml generation still functions as expected without the Edmonton provider block.

The following is the prior conversation context from the user's chat exploration (may be truncated):

User: Remove CaEdmontonProvider and related files as it's not supported anymore. Will need to create multiple PRs. It's part of this feature @mtransitapps/commons-android/issues/129

Assistant: To remove CaEdmontonProvider and related files, multiple pull requests are needed across repositories that reference it. Based on your request and the linked issue, here’s the correct process for each affected repo:

1. commons-android (https://github.com/mtransitapps/commons-android)
   Remove all references to CaEdmontonProvider and its implementation files.

2. ca-edmonton-ets-bus-android (https://github.com/mtransitapps/ca-edmonton-ets-bus-android)
   Remove or update any usage/import of CaEdmontonProvider and provider data (if present).

3. ca-edmonton-ets-train-android (https://github.com/mtransitapps/ca-edmonton-ets-train-android)
   Remove or update any usage/import of CaEdmontonProvider and provider data (if present).

Action plan:

• For each repository, I will:
  • Locate and delete any CaEdmontonProvider source files (Java, Kotlin, resources, test).
  • Remove references in registries, providers lists, or build scripts.
  • Update documentation and README if needed.
  • Link each PR to Custom providers > delete deprecated/unused 🧹 commons-android#129.

Please specify:

• Do you want one PR per repository, or split changes (code, tests, docs) into several PRs within the same repo?
• Do you want the PRs to use a specific branch naming convention (e.g., feature/remove-caedmontonprovider)?
• Should I also clean up any references in code comments or changelogs?

Once you confirm, I’ll begin preparing the PRs.

User: I want 1 PR / repo. Branch name doesn't matter. yet also remove code comments.

Assistant: Great, here's the plan:

For each affected repository:

• One pull request per repo.
• Remove all CaEdmontonProvider-related source code (implementation, test, resources).
• Clean up all references/imports/registry entries.
• Remove related entries in code comments or documentation.
• Branch name can be auto-generated.
• Each PR will link to Custom providers > delete deprecated/unused 🧹 commons-android#129.

Let’s begin with mtransitapps/commons-android. Would you like to proceed in a specific order, or should I start with this core repo and move to ca-edmonton-ets-bus-android and ca-edmonton-ets-train-android next? If you’re ready, I’ll start with commons-android removal now.

User: Can you start with mtransitapps/commons repository

Assistant: Absolutely! I’ll start with the mtransitapps/commons repository.

Task summary for mtransitapps/commons:

• Search for all files, scripts, and code blocks referencing CaEdmontonProvider (including in code comments).
• Remove the implementation and any related assets, scripts, or docs.
• Clean up any references, such as registry lists or provider entries.
• Make a single PR with all changes, referencing Custom providers > delete deprecated/unused 🧹 commons-android#129.

Proceeding to identify all CaEdmontonProvider-related files and code in the mtransitapps/commons repository.

Assistant: Here’s a summary of the changes to remove CaEdmontonProvider and all related code in mtransitapps/commons:

Affected files:

1. shared-modules/app-android/src/main/MTAndroidManifest.xml.MT.sh
   • Remove the conditional block handling CA_EDMONTON_PROVIDER_FILE and the code injection for the Edmonton provider.
   • Remove the associated Edmonton provider code comment.
2. shared/app-android/build.gradle
   • Remove the resValue lines for ca_edmonton_authority, any mention of etslive, and any comment related to CaEdmonton or Edmonton provider.
3. Remove any remaining code comments mentioning CaEdmontonProvider or Edmonton provider in any script, documentation, or code.

No dir...

This pull request was created from Copilot chat.

[gemini-code-assist]

Code Review

This pull request removes the CaEdmontonProvider configuration from the Android manifest generation script and the ca_edmonton_authority resource value from the build configuration. Feedback indicates that the actual source files and resource files for the provider should also be deleted to ensure a complete removal of the deprecated component.

I am having trouble creating individual review comments. Click here to see my feedback.

shared-modules/app-android/src/main/MTAndroidManifest.xml.MT.sh (239-257)

The pull request aims to remove all traces of the deprecated CaEdmontonProvider, but the actual implementation source file (likely CaEdmontonProvider.java or .kt) and the associated resource file (ca_edmonton_values.xml) are not included in the deletions. To fully complete the removal as stated in the description and the original prompt, these files should also be removed from the repository.