Mail service tutorial update#13
Open
piemonkey wants to merge 17 commits intomu-semtech:feature/add-authfrom
Open
Mail service tutorial update#13piemonkey wants to merge 17 commits intomu-semtech:feature/add-authfrom
piemonkey wants to merge 17 commits intomu-semtech:feature/add-authfrom
Conversation
piemonkey
force-pushed
the
mail-service-update
branch
from
5990163 to
79a16ad
Compare
Contributor
|
Looks great! |
If you're reading this trying to figure out why this link doesn't work, maybe the [pull request](mu-semtech/project#5) hasn't been merged yet. In which case, you want to look here: https://github.com/Denperidge-Redpencil/docs-update-project/blob/master/docs/how-tos/troubleshooting---slow-starting-containers.md
If the why-semantic-tech link does not work, please see https://github.com/Denperidge-Redpencil/du-project/blob/master/docs/discussions/why-semantic-tech.md
piemonkey
force-pushed
the
mail-service-update
branch
from
79a16ad to
88bc0a2
Compare
While doing this took the time to make it a little more coherent as a project and to suggest ways to test as you go.
piemonkey
force-pushed
the
mail-service-update
branch
from
88bc0a2 to
cab9d38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had issues trying to get the mail service tutorial working inside mu-delta-service, so I realised it made more sense to base this update on the
feature/add-authbranch, so I could use delta-notifier without having to write docs on how to set up mu-authorization. Right now this PR is very big, but that's because it's based on my tutorials branch, with the feature/add-auth branch merged in. If #12 is merged in and master merged into this branch, then those changes should disappear. If feature/add-auth is merged first, then I can rebase this PR onto the new master.This fixes a few issues with the tutorial and makes it easily testable out of the box with a free email service (which I think was otherwise preventing people from actually using the tutorial code). I also added notes on how to test while working, to make the tutorial easier to follow along with and get working.