fix(backend): call vram.EstimateModelMultiContext (master build broken: undefined vram.EstimateModel) - #10426
Merged
Merged
Conversation
…mate core/backend/options.go called vram.EstimateModel, which does not exist in the vram package (it exposes EstimateModelMultiContext). This broke the build on master (undefined: vram.EstimateModel). Use EstimateModelMultiContext with a nil context-size slice (defaults to a single 8192 estimate); the returned MultiContextEstimate.SizeBytes is exactly what the caller consumes, so size estimation behavior is unchanged. Assisted-by: Claude:claude-opus-4-8 Signed-off-by: Ettore Di Giacinto <mudler@localai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
core/backend/options.go:93callsvram.EstimateModel(ctx, input), but thevrampackage has no such function (it exposesEstimateModelMultiContext). Master HEAD does not compile:This breaks the Go build,
golangci-lint,build-test,tests-ui-e2e, and the image builds on every PR (introduced by #9527).Fix
Call
vram.EstimateModelMultiContext(ctx, input, nil). Anilcontext-size slice defaults to a single 8192-token estimate, and the returnedMultiContextEstimate.SizeBytesis exactly what the caller already consumes (result.SizeBytes), so model size-estimation behavior is unchanged.One-line change; build and
golangci-lintpass oncore/backend/....Assisted-by: Claude:claude-opus-4-8
🤖 Generated with Claude Code