fix(test): update e2e UpdateProgress calls for new cancellable arg - #10460
Merged
Conversation
PR #10454 added a `cancellable bool` parameter to GalleryStore.UpdateProgress but missed two callers under tests/e2e/distributed, breaking the build on master (golangci-lint and tests-e2e-backend both failed to compile with "not enough arguments in call to ... UpdateProgress"). Pass cancellable=true (both ops are downloading installs, which are cancellable) and assert the flag is persisted, exercising the new behavior. Signed-off-by: Ettore Di Giacinto <mudler@localai.io> Assisted-by: Claude:claude-opus-4-8 [Claude Code]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #10454 added a
cancellable boolparameter toGalleryStore.UpdateProgress, but two callers undertests/e2e/distributed/still used the old 4-arg signature. This broke the build onmaster:Both
golangci-lintandtests-e2e-backendfailed to compile as a result. (Thetestsjob failure on #10454 was a separate, unrelated CodeQL SARIF-upload error caused by the source branch being deleted on merge - not a code issue.)Fix
Pass
cancellable=trueto both calls (each op is a downloading install, which is cancellable) and assert the flag is persisted, exercising the behavior #10454 introduced.Testing
go vet ./tests/e2e/distributed/compiles clean.