feature: add makefile - #18
Merged
Merged
Conversation
Contributor
Author
|
Suggestion: To keep the history clean, i'd recommend doing a Squash and merge. |
Owner
|
Thanks! I've tested it locally, build target works, so that's going in the good direction. There are just small nits that I've commented in the single commits - maybe better to split into separate PRs so we can merge them singularly? |
Owner
|
also.. ❤️ the webui integration! |
This reverts commit 5fab6ab.
mudler
force-pushed
the
feature/devcontainer
branch
from
April 15, 2023 22:59
e10a895 to
7fdff40
Compare
…lama-cli into feature/devcontainer
mudler
reviewed
Apr 15, 2023
| libbinding.a | ||
|
|
||
| # llama models | ||
| models |
Owner
There was a problem hiding this comment.
if we put that in ignore, than it's more commands for the user to type - my plan was to leave a models folder with a .keep file checked out, so you can just copy the models in
mudler
changed the title
mudler
changed the title
walcz-de
added a commit
to walcz-de/LocalAI
that referenced
this pull request
Jul 9, 2026
Runtime-verifiziert: hipengine.SamplingParams(max_tokens, temperature, top_p, ignore_eos, kv_storage, …) — KEIN top_k/seed/stop. Diese Proto-Felder daher aus _SAMPLING_MAP entfernt (statt sie zur Laufzeit defensiv zu droppen). Aus dem Blueprint-Runtime-Durchstich (Task mudler#18). Signed-off-by: Stefan Walcz <stefan.walcz@walcz.de> Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TudBpPAvgnGgWpYwoe7ZZs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps running the api in debug mode directly inside the docker container.
Added a Makefile (used a template i found online), but i'm not a Golang dev, so no idea if i did it right.
Seems like there are some steps of the build in the Dockerfile that has no influence on the build, so look at the Makefile carefuly before merging. I've tested it, but rather you test it yourself as well.
And found a type (wrong case) for an environment variable.