Skip to content

VideoEngine uses unguarded POSIX stat in native Windows build #648

Description

@localai-bot

Defect

Current main at cefacd2d00cb9b4776331cd213116773cd97f811 adds src/vllm/multimodal/video_engine.cpp with an unconditional <sys/stat.h> include and two ::stat calls. The configured Windows portability checker rejects all three sites, so the native MSVC release lanes cannot compile this shared VideoEngine surface.

Reproduction

python3 scripts/check-windows-portability.py --root . --build-dir build-review-fix
ERROR: src/vllm/multimodal/video_engine.cpp:21: unguarded POSIX include/call reaches Windows
ERROR: src/vllm/multimodal/video_engine.cpp:59: unguarded POSIX include/call reaches Windows
ERROR: src/vllm/multimodal/video_engine.cpp:64: unguarded POSIX include/call reaches Windows

Required outcome

Use the standard C++ filesystem surface for directory/existence queries, preserving error behavior and detector semantics. Do not guard or exempt the POSIX path. Add/port focused behavior coverage if existing VideoEngine tests do not distinguish regular files, directories, missing paths, and filesystem errors.

This regression blocks the Windows binary release work in PR #524.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions