fix(h3): route video device selection through the backend seam - #134
Closed
localai-bot wants to merge 2 commits into
Closed
fix(h3): route video device selection through the backend seam#134localai-bot wants to merge 2 commits into
localai-bot wants to merge 2 commits into
Conversation
FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
Keep the public ABI selector at 0=CPU and 1=CUDA while converting it once to vt::DeviceType. The H3 shared layer now creates one queue through GetBackend(device_type), restoring the device-leakage ratchet without an allowlist or baseline change.\n\nHelper row: row/ARCH-ONE-SURFACE (PR #134).\n\nFOLLOWING_AGENTS_PROTOCOL\nAssisted-by: Codex:gpt-5 [Codex]
mudler
added a commit
that referenced
this pull request
Aug 7, 2026
Keep the public ABI selector at 0=CPU and 1=CUDA while converting it once to vt::DeviceType. The H3 shared layer now creates one queue through GetBackend(device_type), restoring the device-leakage ratchet without an allowlist or baseline change. Helper row: row/ARCH-ONE-SURFACE-H3-DEVICE (PR #135; replaces #134). FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
Collaborator
Author
richiejp
pushed a commit
to richiejp/vllm.cpp
that referenced
this pull request
Aug 8, 2026
Replacement for malformed-trailer PR mudler#134 on row/ARCH-ONE-SURFACE-H3-DEVICE. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARCH-ONE-SURFACE H3 follow-up: repair the device-specific references introduced by the ABI v12 video fold.
Change
device: 0=CPU, 1=CUDA.MiniMaxH3VideoDeviceType.GetBackend(device_type)and use that queue's device.RED -> GREEN evidence
python3 scripts/check-device-leakage.py --report-> DSR 34,kcuda=2, baseline 32, exit 1.5d03059e: DSR 32,kcuda=0, baseline unchanged, no allowlist.python3 tests/scripts/test_device_leakage.py: 25/25 pass.Honest pending gate
The from-scratch local CPU build was stopped at the operator's request when the shared filesystem reached 100%;
test_minimax_h3_video_fold, H3, C API, and CPU build/tests are NOT claimed locally and must pass GitHub CI before review/merge. No GPU job, download, benchmark, release-row edit, baseline change, or allowlist was made.Draft remains open for the operator's fresh mutation review.