fix(surface): remove shared CUDA literals from device selection - #138
Closed
localai-bot wants to merge 2 commits into
Closed
fix(surface): remove shared CUDA literals from device selection#138localai-bot wants to merge 2 commits into
localai-bot wants to merge 2 commits into
Conversation
Materialize the isolated ARCH-ONE-SURFACE helper claim and record the inherited PR #136 DSR regression as a pending correctness-only checkpoint. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
Preserve ABI-v14 device values and public names while removing shared CUDA literals from device selection. Resolve the canonical device name through the platform registry and propagate its DeviceType, with mutation-sensitive CPU gates. FOLLOWING_AGENTS_PROTOCOL Assisted-by: Codex:gpt-5 [Codex]
Collaborator
Author
|
Superseded by #139. This PR's feature commit omitted the required helper row/PR reference in its commit message, so it was not rewritten or force-pushed. The tested change was replayed from current main on the clean replacement row branch with protocol-compliant metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Repair the inherited PR #136 device-leakage regression through the platform/backend abstraction. ABI-v14 remains 0=auto, 1=cpu, 2=cuda; public names and loud absent-CUDA failure are unchanged. H3 source is untouched.
Architecture
Device::kNamedPlatform.DeviceName()remains the canonical public spelling (cuda).FindPlatformByNameresolves that name through the platform registry.DeviceType; it does not branch on CUDA.The resolver test supplies
kXPUand requireskXPUback, so a hidden hardcoded CUDA return is mutation-sensitive.RED / GREEN
b44ad337:kcuda=7, total DSR 39 vs baseline 32.kcuda=0) with baseline/allowlist unchanged.-Werror:test_platform: 11/11 cases, 85 assertions.test_loaded_engine_dense: 9/9 cases, 65 assertions.test_capi: 45/45 cases, 428 assertions.No CUDA runtime, model download, service change, benchmark, or release artifact. The existing CUDA-build A/B remains a named residual.
Exact reviewed head:
285987a6c83d4f93b0698d2041851588f12b3bd4.FOLLOWING_AGENTS_PROTOCOL