Skip to content

spec(gemma4): repair #140 integration regressions - #158

Draft
localai-bot wants to merge 4 commits into
mainfrom
row/MODEL-TEXT-gemma4-gemma4-for-causal-lm
Draft

spec(gemma4): repair #140 integration regressions#158
localai-bot wants to merge 4 commits into
mainfrom
row/MODEL-TEXT-gemma4-gemma4-for-causal-lm

Conversation

@localai-bot

@localai-bot localai-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Scope

Committed written repair plan only for MODEL-TEXT-gemma4-gemma4-for-causal-lm. No production or test fix is included.

Spec: .agents/specs/main-regression-repair-2026-08-08.md
Immutable reviewed head: e0b185c

Corrected root causes

  1. gemma4_moe.cpp has two direct vt::GeluAndMul calls, not SiluAndMul. They violate the shared merged-GEMM/MoE MlpGateUpMethodBase family; this is not the residual-norm FusedChain glue seam.
  2. runner.cpp hard-codes kCUDA in shared async-input eligibility despite the device-leakage baseline binding kcuda=0. Eligibility must be unified host readability OR a Platform-advertised device mirror.

The plan forbids an allowlist, DSR waiver, baseline increase, or #140 revert; requires two independent TDD commits and mutation review; then merges the repair before reconciling #141 keyed records wholesale from current main.

Intake

Validation

Green: doc-checkpoint staged/commit/range, public-doc checker + 41 mutations, agent-record + 13 mutations, protocol consistency, NOW-current, diff check, PR-size (0 non-exempt lines).

Expected red-first baseline at assigned base 1ce0d66: check-fusion-consistency and test_check_fusion_consistency both name gemma4_moe. Current main later added an allowlist entry; the plan requires removing it as part of the real repair.

Draft remains stopped for written-spec review.

FOLLOWING_AGENTS_PROTOCOL

@mudler
mudler force-pushed the row/MODEL-TEXT-gemma4-gemma4-for-causal-lm branch from e0b185c to d6ad78b Compare August 8, 2026 21:42
mudler added 4 commits August 8, 2026 21:57
Reserve MODEL-TEXT-gemma4-gemma4-for-causal-lm for the written repair plan. No repository content changes.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Codex:GPT-5 [Codex]
Ground the two direct GeGLU call sites and the runner device-identity leak, bind red-first tests, two independent repair commits, mutation review, and the #141 reconciliation sequence.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Codex:GPT-5 [Codex]
Bind host-backed and resident expert slabs through the shared GeGLU gate-up method while preserving the BF16 activation boundary and removing the temporary merged-GEMM exception.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Codex:GPT-5 [Codex]
Honor genuine unified host readability as well as an advertised sampled-token mirror, preserving discrete no-mirror rollback and the device-leakage ratchet.

FOLLOWING_AGENTS_PROTOCOL

Following-Agents-Protocol: true
AI-Assisted: true
Assisted-by: Codex:GPT-5 [Codex]
@mudler
mudler force-pushed the row/MODEL-TEXT-gemma4-gemma4-for-causal-lm branch from d6ad78b to 3d0f669 Compare August 8, 2026 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants