[core] Use babel-plugin-optimize-react#16072
Closed
eps1lon wants to merge 1 commit into
Closed
Conversation
|
@material-ui/core: parsed: -0.57% 😍, gzip: +0.78% Details of bundle changes.Comparing: 14bbd57...89d372a
|
Member
Author
Expected result. Without benchmarks (parse time, property access perf) it's hard to tell if the longer load time over the wire is justified. Need a way to compare sizes using brotli but I'm missing usage numbers for that as well. |
70cd82b to
ca9f702
Compare
1 task
ca9f702 to
89d372a
Compare
Member
Author
|
In it's current form not optimal. An in-house fork (#16860) is likely the better option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DONT_MERGE_BEFORE_https://github.com/facebook/create-react-app/pull/6219_OR_YOU_WILL_BE_FIREDCloses #15238