You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
good call on the fuzzing. I found a surprising behavior where if a variable sized component has a zero-len value it will not put anything into the multiaddr string. This means that the string /http-path/http is ambigous since it's not clear if it's http-path with no value and an http component, or an http-path with the value "http".
To disambiguate, I've made it a requirement for there to be at least some value in the http-path component. Which seems to be the same thing that other length prefixed sized components do (e.g. dns, p2p). This library should probably make it possible to represent components with a value that has len 0 (e.g. /http-path//http), but nothing currently needs this, so likely not a priority.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context here: multiformats/multiaddr#164