Conversation
ghost
assigned
This was referenced Feb 22, 2019
vasco-santos
approved these changes
Feb 25, 2019
| if (proto.path) { | ||
| tuples.push([ | ||
| part, | ||
| // TODO: should we need to check each path part to see if it's a proto? |
Member
There was a problem hiding this comment.
Maybe we can go with this now, and when we add new protocols we thing about it?
Contributor
Author
There was a problem hiding this comment.
Yeah. It should be reasonable for us to have an address that's /unix/a/b/c/d/e/f/ip4/0.0.0.0/tcp/1234, but users would need to avoid addresses like /unix/c/p2p/d.sock/ip4/0.0.0.0/tcp/12341, since it has a proto name in the unix path. Having at least basic support for unix addresses is the important thing right now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also updates the protocol table to match the latest at multiaddr/protocols.csv
resolves #82