Add httpath multiaddr component#324
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
willscott
approved these changes
May 24, 2023
masih
approved these changes
May 25, 2023
Member
masih
left a comment
masih
left a comment
There was a problem hiding this comment.
Many thanks for getting this added 🚀
lidel
requested changes
May 31, 2023
Member
There was a problem hiding this comment.
For the record, me and @MarcoPolo raised concerns in ipni/go-libipni#42, would be good to keep this open until we understand there is utility of this outside of IPNI and using https:// URLs.
Contributor
|
Let's do http-path multiformats/multiaddr#164 instead |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/ipni/go-libipni/blob/dfad9b30814eaede8c7e934f120b632bb180511c/maurl/convert.go#L35
Ref: ipni/go-libipni#42