Conversation
This commit is a backport of rust-libp2p commit [ad0807b3f3588f2a3f507d6e948932a476ca0753]. [ad0807b3f3588f2a3f507d6e948932a476ca0753]: libp2p/rust-libp2p@ad0807b Original commit message: --- Use unsigned-varints, add BLAKE2 support in multihash (#525) * Add support for unsigned varints * Depend on unsigned-varint 0.2 without default features * Change hash code type from u8 to u64 * Fix hash codes and enum variants for BLAKE2 to fit the standard (see #524) * Run cargo fmt on crate * Expand hash_types test to include all variants * Add support for BLAKE2b-512 and BLAKE2s-256 * Depend on blake2 crate 0.7 with no default features * Update encode! macro for support for blake2 crate * Update all tests to include BLAKE2b-512 and BLAKE2s-256 * Reduce hash code size from u64 to u16 * Fix typo in doc comment * Bump tiny-keccak to version 1.4 * Remove unnecessary default-features = false in Cargo.toml
| edition = "2018" | ||
|
|
||
| [dependencies] | ||
| blake2 = { version = "0.7", default-features = false } |
Member
There was a problem hiding this comment.
Please use blake2b_simd and blake2s_simd instead. I know this changes what rust-libp2p does, but they are much better in terms of performance
Merged
Member
Author
|
Those changes got merged with #40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of rust-libp2p commit ad0807b3f3588f2a3f507d6e948932a476ca0753, which adds BLAKE2 support.