Tokens supply format from plugin by bogdan-rosianu · Pull Request #1505 · multiversx/mx-api-service

bogdan-rosianu · 2025-06-03T11:24:04Z

Reasoning

Proposed Changes

How to test

github-actions · 2025-06-03T11:26:54Z

k6 load testing comparison.
Base Commit Hash: b956bbf
Target Commit Hash: bc1caba

Metric	Base				Target				Diff
Metric	Avg	Max	90	95	Avg	Max	90	95	Avg	Max	90	95
Nodes	50.76	1129.25	53.86	56.00	50.37	1065.69	53.23	55.23	-0.78% ✅	-5.63% ✅	-1.17% ✅	-1.38% ✅
Pool	49.76	375.03	53.97	56.14	49.57	519.68	53.14	55.10	-0.36% ✅	+38.57% 🔴	-1.55% ✅	-1.85% ✅
Blocks	56.33	1112.37	54.63	58.37	55.67	1085.39	53.57	56.59	-1.18% ✅	-2.43% ✅	-1.95% ✅	-3.04% ✅
Transactions	64.24	2467.62	54.85	57.89	63.22	2209.85	54.05	56.44	-1.59% ✅	-10.45% ✅	-1.46% ✅	-2.52% ✅
Tokens	50.00	573.00	54.00	56.19	49.77	584.34	53.17	55.12	-0.47% ✅	+1.98% 🔴	-1.55% ✅	-1.90% ✅
Accounts	50.99	1423.88	54.06	56.07	50.76	1468.00	53.26	55.27	-0.47% ✅	+3.10% 🔴	-1.48% ✅	-1.43% ✅
Mex	49.81	445.57	54.02	56.15	48.85	126.87	53.13	54.98	-1.91% ✅	-71.53% ✅	-1.64% ✅	-2.09% ✅
Test Run Duration	60002.16				60004.29

Legend: Avg - Average Response Time, Max - Maximum Response Time, 90 - 90th Percentile, 95 - 95th Percentile
All times are in milliseconds.

dragos-rebegea · 2025-06-03T14:01:17Z

  async getTokenSupply(identifier: string): Promise<EsdtSupply> {
-    const { supply, minted, burned, initialMinted } = await this.gatewayService.getEsdtSupply(identifier);
+    const esdtSupply = await this.gatewayService.getEsdtSupply(identifier);
+    this.pluginService.formatTokenSupply(identifier, esdtSupply);


this should not fail if the formatTokenSupply is not defined in the plugin module

yes, just tested and it works

Copilot

Pull Request Overview

This PR integrates plugin-based token supply formatting functionality into the Esdt endpoints.

Injection and usage of PluginService in EsdtService to format token supply data.
Addition of PluginModule to EsdtModule's dependency list.
Introduction of the stub method formatTokenSupply in PluginService for potential supply formatting.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/endpoints/esdt/esdt.service.ts	PluginService injection and usage added for token supply formatting.
src/endpoints/esdt/esdt.module.ts	PluginModule added to module dependencies.
src/common/plugins/plugin.service.ts	New formatTokenSupply method stub introduced.

Copilot · 2025-06-03T14:59:48Z

  async getTokenSupply(identifier: string): Promise<EsdtSupply> {
-    const { supply, minted, burned, initialMinted } = await this.gatewayService.getEsdtSupply(identifier);
+    const esdtSupply = await this.gatewayService.getEsdtSupply(identifier);
+    this.pluginService.formatTokenSupply(identifier, esdtSupply);


The call to formatTokenSupply does not capture any return value. If the intent is to modify esdtSupply, consider either returning the formatted result or documenting that the method works via side effects.

Suggested change

this.pluginService.formatTokenSupply(identifier, esdtSupply);

esdtSupply = this.pluginService.formatTokenSupply(identifier, esdtSupply);

Copilot · 2025-06-03T14:59:48Z


  async processAbout(_about: About): Promise<void> { }
+
+  formatTokenSupply(_identifier: string, _esdtSupply: EsdtSupply) { }


The method formatTokenSupply is currently an empty stub. Consider adding a comment or a placeholder implementation (e.g., a NotImplemented error) to clarify its intended behavior.

* Enhance MexTokenService to calculate and store token volumes for base and quote tokens in getAllMexTokensRaw method * extend aws s3 config * update configs * update s3 configs * add support for new NFT events * add maximum process retries * add unit tests * ferch token price from highest liquidity pool * emit also deleteCacheKeys * undo process reries * fix tests * Proposer fix (#1498) * proposer fix * proposer fix * proposer fix * fix getBlock * fixes after review Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> * add execution order sorting using miniBlocksDetails from Elasticsearch (#1504) * add execution order sorting using miniBlocksDetails from Elasticsearch * fixes after review * fixes after review * fix userUndelegatedList field (#1507) * fix userUndelegatedList field * use ?? instead of [] to handle undefined case * collections count subType required false fix (#1509) * tokens supply format from plugin (#1505) * fix collection set fields (#1510) * fix collection set fields * fixes after review * add configurable response compression with gzip deflate support + update package json (#1512) * add configurable response compresion * set true compression for testnet env * refactor processNFtCollections method * update package * update version of node * update unit test yaml * getNfts parallel execution * compression flag false by default * improve getSingleNFt * getNftsCollection increase performance * undo last commit * Integrate last sdk nestjs (#1516) * update to latest sdk version * fixes for latest sdk version * add package-lock * fix unit tests * Packages security issues 2 (#1517) * fix packages * add package-lock * add missing packages * remove unneeded package * fix mongo connection * Api 672 add timestampMs field into transaction response (#1518) * Add timestampMs field to Transaction interface and class * update specs * update accounts spec * Add normalizeTimestampMs method for timestamp conversion (#1519) * Enhance account filtering by adding 'withBalance' query option to account endpoints and update ElasticIndexerHelper to support balance filtering. This allows users to filter accounts based on their balance status. (#1521) * add events filtered by order (#1523) * Refactor content type validation in NftMediaService to handle media types correctly by stripping parameters from the content type string. (#1527) * use events index instead of logs (#1514) * use events index instead of logs * configurable migrated indices * added protection for empty fields * fix log address * add transaction get unit tests (#1525) --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> * fixes after merge + new sdknestjs versions * remove test file * fix tx value parsing * treat missing receiver --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Gabriel Matei <gabrielvmatei@gmail.com> Co-authored-by: Rebegea Dragos-Alexandru <42241923+dragos-rebegea@users.noreply.github.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> Co-authored-by: Gutica Stefan <123564494+GuticaStefan@users.noreply.github.com>

* Enhance MexTokenService to calculate and store token volumes for base and quote tokens in getAllMexTokensRaw method * extend aws s3 config * update configs * update s3 configs * fix transfers count with relayed txs (#1496) * add support for new NFT events * add maximum process retries * add unit tests * ferch token price from highest liquidity pool * emit also deleteCacheKeys * undo process reries * fix tests * Proposer fix (#1498) * proposer fix * proposer fix * proposer fix * fix getBlock * fixes after review Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> * add execution order sorting using miniBlocksDetails from Elasticsearch (#1504) * add execution order sorting using miniBlocksDetails from Elasticsearch * fixes after review * fixes after review * fix userUndelegatedList field (#1507) * fix userUndelegatedList field * use ?? instead of [] to handle undefined case * collections count subType required false fix (#1509) * tokens supply format from plugin (#1505) * fix collection set fields (#1510) * fix collection set fields * fixes after review * add configurable response compression with gzip deflate support + update package json (#1512) * add configurable response compresion * set true compression for testnet env * refactor processNFtCollections method * update package * update version of node * update unit test yaml * getNfts parallel execution * compression flag false by default * improve getSingleNFt * getNftsCollection increase performance * undo last commit * Integrate last sdk nestjs (#1516) * update to latest sdk version * fixes for latest sdk version * add package-lock * fix unit tests * Packages security issues 2 (#1517) * fix packages * add package-lock * add missing packages * remove unneeded package * fix mongo connection * Api 672 add timestampMs field into transaction response (#1518) * Add timestampMs field to Transaction interface and class * update specs * update accounts spec * Add normalizeTimestampMs method for timestamp conversion (#1519) * Enhance account filtering by adding 'withBalance' query option to account endpoints and update ElasticIndexerHelper to support balance filtering. This allows users to filter accounts based on their balance status. (#1521) * add events filtered by order (#1523) * Refactor content type validation in NftMediaService to handle media types correctly by stripping parameters from the content type string. (#1527) * use events index instead of logs (#1514) * use events index instead of logs * configurable migrated indices * added protection for empty fields * fix log address * add transaction get unit tests (#1525) --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> * fix ESDTTransfer duplicated events (#1526) * use events index instead of logs * configurable migrated indices * added protection for empty fields * fix log address * add transaction get unit tests (#1525) * fix duplicated events --------- Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> * update MetaESDT tokens (#1520) * update MetaESDT tokens * update imports * nft collections es improvements (#1530) * ES collections improvements * getNfts improvements * improve bulkProcessTransactions * fixes * fixes * fixes * refactor getSmartContractResultsRaw() * improve nftCollection processing * eslint fix --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Gabriel Matei <gabrielvmatei@gmail.com> Co-authored-by: bogdan-rosianu <51945539+bogdan-rosianu@users.noreply.github.com> Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> Co-authored-by: Gutica Stefan <123564494+GuticaStefan@users.noreply.github.com>

* update andromeda config template enable epoch (#1502) * Merge development into main (#1511) * Enhance MexTokenService to calculate and store token volumes for base and quote tokens in getAllMexTokensRaw method * extend aws s3 config * update configs * update s3 configs * fix transfers count with relayed txs (#1496) * add support for new NFT events * add maximum process retries * add unit tests * ferch token price from highest liquidity pool * emit also deleteCacheKeys * undo process reries * fix tests * Proposer fix (#1498) * proposer fix * proposer fix * proposer fix * fix getBlock * fixes after review Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> * add execution order sorting using miniBlocksDetails from Elasticsearch (#1504) * add execution order sorting using miniBlocksDetails from Elasticsearch * fixes after review * fixes after review * fix userUndelegatedList field (#1507) * fix userUndelegatedList field * use ?? instead of [] to handle undefined case * collections count subType required false fix (#1509) * tokens supply format from plugin (#1505) * fix collection set fields (#1510) * fix collection set fields * fixes after review * add configurable response compression with gzip deflate support + update package json (#1512) * add configurable response compresion * set true compression for testnet env * refactor processNFtCollections method * update package * update version of node * update unit test yaml * getNfts parallel execution * compression flag false by default * improve getSingleNFt * getNftsCollection increase performance * undo last commit * Integrate last sdk nestjs (#1516) * update to latest sdk version * fixes for latest sdk version * add package-lock * fix unit tests * Packages security issues 2 (#1517) * fix packages * add package-lock * add missing packages * remove unneeded package * fix mongo connection * Api 672 add timestampMs field into transaction response (#1518) * Add timestampMs field to Transaction interface and class * update specs * update accounts spec * Add normalizeTimestampMs method for timestamp conversion (#1519) * Enhance account filtering by adding 'withBalance' query option to account endpoints and update ElasticIndexerHelper to support balance filtering. This allows users to filter accounts based on their balance status. (#1521) * add events filtered by order (#1523) * Refactor content type validation in NftMediaService to handle media types correctly by stripping parameters from the content type string. (#1527) * use events index instead of logs (#1514) * use events index instead of logs * configurable migrated indices * added protection for empty fields * fix log address * add transaction get unit tests (#1525) --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> * fix ESDTTransfer duplicated events (#1526) * use events index instead of logs * configurable migrated indices * added protection for empty fields * fix log address * add transaction get unit tests (#1525) * fix duplicated events --------- Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> * update MetaESDT tokens (#1520) * update MetaESDT tokens * update imports * nft collections es improvements (#1530) * ES collections improvements * getNfts improvements * improve bulkProcessTransactions * fixes * fixes * fixes * refactor getSmartContractResultsRaw() * improve nftCollection processing * eslint fix --------- Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Gabriel Matei <gabrielvmatei@gmail.com> Co-authored-by: bogdan-rosianu <51945539+bogdan-rosianu@users.noreply.github.com> Co-authored-by: bogdan-rosianu <bogdan.rosianu@yahoo.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> Co-authored-by: Gutica Stefan <123564494+GuticaStefan@users.noreply.github.com> * merge main to development - fixes after merge * fix lint --------- Co-authored-by: Rebegea Dragos-Alexandru <42241923+dragos-rebegea@users.noreply.github.com> Co-authored-by: cfaur09 <catalinfaurpaul@gmail.com> Co-authored-by: Gabriel Matei <gabrielvmatei@gmail.com> Co-authored-by: Catalin Faur <52102171+cfaur09@users.noreply.github.com> Co-authored-by: Gutica Stefan <123564494+GuticaStefan@users.noreply.github.com>

tokens supply format from plugin

bc1caba

dragos-rebegea reviewed Jun 3, 2025

View reviewed changes

cfaur09 approved these changes Jun 3, 2025

View reviewed changes

dragos-rebegea requested a review from Copilot June 3, 2025 14:59

Copilot AI reviewed Jun 3, 2025

View reviewed changes

cfaur09 assigned bogdan-rosianu Jun 4, 2025

dragos-rebegea approved these changes Jun 4, 2025

View reviewed changes

dragos-rebegea merged commit 87a4c5a into development Jun 4, 2025
6 checks passed

dragos-rebegea deleted the add-plugin-token-supply-format branch June 4, 2025 11:56

dragos-rebegea pushed a commit that referenced this pull request Jun 4, 2025

tokens supply format from plugin (#1505)

8651f00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tokens supply format from plugin#1505

Tokens supply format from plugin#1505
dragos-rebegea merged 1 commit into
developmentfrom
add-plugin-token-supply-format

bogdan-rosianu commented Jun 3, 2025

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

dragos-rebegea Jun 3, 2025

Uh oh!

bogdan-rosianu Jun 3, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jun 3, 2025

Uh oh!

Copilot AI Jun 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	this.pluginService.formatTokenSupply(identifier, esdtSupply);
	esdtSupply = this.pluginService.formatTokenSupply(identifier, esdtSupply);


		async processAbout(_about: About): Promise<void> { }

		formatTokenSupply(_identifier: string, _esdtSupply: EsdtSupply) { }

Conversation

bogdan-rosianu commented Jun 3, 2025

Reasoning

Proposed Changes

How to test

Uh oh!

github-actions Bot commented Jun 3, 2025

Uh oh!

dragos-rebegea Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

bogdan-rosianu Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants