Resume continuation on cancellation when using .async()#1334
Merged
Conversation
RomanPodymov
requested changes
Feb 21, 2024
| @available(iOS 13.0, macOS 10.15, tvOS 13.0, watchOS 6.0, *) | ||
| func testAsyncPromiseCancel() async throws { | ||
| do { | ||
| let p = after(seconds: 0).done { _ in |
Collaborator
There was a problem hiding this comment.
Why not
let p = after(seconds: 0).then { _ in
throw LocalError.cancel
}.done {
XCTFail()
}.catch { _ in
XCTFail()
}
?
Collaborator
There was a problem hiding this comment.
@ChaosCoder OK, I will fix this, thanks for the pull request.
RomanPodymov
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
.async()with a cancelled promise, the continuation was never completed, because the error was ignored (default catch policy ignores cancellation). This fixes it.I also already bumped the version to 8.1.2 to make it less work ;)