Skip to content

Fix #1332#1342

Merged
RomanPodymov merged 9 commits into
mxcl:masterfrom
RomanPodymov:feature/privacy_manifest
May 11, 2024
Merged

Fix #1332#1342
RomanPodymov merged 9 commits into
mxcl:masterfrom
RomanPodymov:feature/privacy_manifest

Conversation

@RomanPodymov

Copy link
Copy Markdown
Collaborator

Hello.
Thank you for PromiseKit.
Fix #1332.

RomanPodymov and others added 3 commits September 30, 2023 20:54
Co-authored-by: Max Howell <mxcl@me.com>
@RomanPodymov RomanPodymov marked this pull request as draft April 6, 2024 11:04
@RomanPodymov RomanPodymov mentioned this pull request Apr 10, 2024
@mxcl

mxcl commented May 8, 2024

Copy link
Copy Markdown
Owner

Is this ready?

@RomanPodymov

Copy link
Copy Markdown
Collaborator Author

Is this ready?

Hello @mxcl
Not yet, SPM is failing. Or maybe I can fix SPM later.

@RomanPodymov RomanPodymov marked this pull request as ready for review May 11, 2024 00:09
@RomanPodymov

Copy link
Copy Markdown
Collaborator Author

Is this ready?

Now it's ready.

@RomanPodymov RomanPodymov merged commit 4c31ef1 into mxcl:master May 11, 2024
@RomanPodymov RomanPodymov deleted the feature/privacy_manifest branch May 11, 2024 07:57
@jayeshkawli

Copy link
Copy Markdown

@RomanPodymov Thank you for the fix. Much appreciated. Can we also make a release so that we can update our dependencies?

@RomanPodymov

Copy link
Copy Markdown
Collaborator Author

Hello @jayeshkawli
Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

@jayeshkawli

Copy link
Copy Markdown

Hello @jayeshkawli Can you reproduce the issue using master branch? Currently I don't have any project with PromiseKit that I can upload to TestFlight.

I am not sure what you mean, can you please elaborate? To my original question, I meant making a next release like from this page https://github.com/mxcl/PromiseKit/releases so that we can fetch this change through SPM/Cocoapods. Or I can also do that if I have necessary permissions.

@ghost ghost mentioned this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Privacy Manifest

3 participants