fix: remove server URL from test oracle GitHub comment#1005
Merged
Conversation
Keep detailed server URL and status code in logs for debugging, but use a generic message in the PR comment to avoid exposing internal infrastructure details.
Review Summary by QodoRemove server URL from Test Oracle GitHub comments
WalkthroughsDescription• Remove server URL from GitHub PR comments for security • Keep detailed URL and status code in logs for debugging • Update test assertions to match generic comment format Diagramflowchart LR
A["Test Oracle Error"] --> B["Log with URL details"]
A --> C["Post generic comment"]
B --> D["Operator debugging"]
C --> E["No infrastructure exposure"]
File Changes1. webhook_server/libs/test_oracle.py
|
Code Review by Qodo
1.
|
Collaborator
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (2)
WalkthroughThe PR changes the health-check failure comment posted by the Test Oracle path to a new formatted string that includes status_info but omits the server URL. The test asserting that comment was updated to expect the exact new message. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@webhook_server/tests/test_test_oracle.py`:
- Line 91: Update the assertion in test_health_check_failure_posts_comment to
match the exact static message used elsewhere: replace the substring check that
asserts "not responding" in call_args[0][1] with an equality assertion comparing
call_args[0][1] to "Test Oracle server is not responding, skipping test
analysis" so both tests use the same exact-match style (target the assertion
inside test_health_check_failure_posts_comment that currently inspects
call_args[0][1]).
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (2)
webhook_server/libs/test_oracle.pywebhook_server/tests/test_test_oracle.py
Only the server URL is removed from the PR comment. The HTTP status code (e.g., "(status 503)") is still included to help users understand the failure mode.
Collaborator
Author
|
/verified |
Collaborator
|
New container for ghcr.io/myk-org/github-webhook-server:latest published |
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Summary by CodeRabbit