Skip to content

fix(sidecar): remove hardcoded ACPX extension path that breaks npm hoisting #1135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myakove merged 2 commits into from
Jun 23, 2026
Merged

fix(sidecar): remove hardcoded ACPX extension path that breaks npm hoisting #1135

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4793993
fix(sidecar): remove hardcoded ACPX extension path that breaks npm ho…
myakove Jun 23, 2026
e33dbf3
fix(examples): add sidecar config and healthcheck to docker-compose e…
myakove Jun 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion entrypoint.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ set -euo pipefail
# Start Pi SDK sidecar in background with lifecycle coupling
if [ -f "$APP_DIR/sidecar-helper/dist/server.js" ]; then
export SIDECAR_PORT="${SIDECAR_PORT:-9100}"
export SIDECAR_ACPX_EXTENSION_PATH="$APP_DIR/sidecar-helper/node_modules/@myk-org/pi-sidecar/node_modules/pi-orchestrator-config/extensions/acpx-provider/index.ts"
node "$APP_DIR/sidecar-helper/dist/server.js" &
SIDECAR_PID=$!
echo "[sidecar] Started Pi SDK sidecar (PID $SIDECAR_PID) on port $SIDECAR_PORT"
Expand Down
11 changes: 11 additions & 0 deletions examples/docker-compose.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ services:
- "./webhook_server_data_dir:/home/podman/data:Z" # Should include config.yaml and webhook-server.private-key.pem
# Mount temporary directories to prevent boot ID mismatch issues
- "/tmp/podman-storage-${USER:-1000}:/tmp/storage-run-1000"
# - $HOME/.config/gcloud:/home/podman/.config/gcloud:ro # Mount Google Cloud credentials for Vertex AI
environment:
- PUID=1000
- PGID=1000
Expand All @@ -18,6 +19,10 @@ services:
- VERIFY_CLOUDFLARE_IPS=1 # Verify hook request is from Cloudflare IPs
- ENABLE_LOG_SERVER=true # Enable log viewer endpoints (default: false)
- ENABLE_MCP_SERVER=false # Enable MCP server for AI agent integration (default: false)
# Pi sidecar (AI features)
# - ACPX_AGENTS=cursor # Enable cursor model discovery for AI features
# - VERTEX_CLAUDE_1M=true # Enable Claude 1M context window models via Vertex AI
# - SIDECAR_PORT=9100 # Pi sidecar port (default: 9100)
# AI CLI API keys for pr-test-oracle integration
# - ANTHROPIC_API_KEY=sk-ant-xxx # Claude Code
# - GEMINI_API_KEY=xxx # Gemini CLI
Expand All @@ -26,4 +31,10 @@ services:
ports:
- "5000:5000"
privileged: true
healthcheck:
test: ["CMD-SHELL", "curl -f http://localhost:5000/webhook_server/healthcheck && curl -f http://localhost:${SIDECAR_PORT:-9100}/health"]
interval: 30s
timeout: 10s
retries: 3
start_period: 30s
restart: unless-stopped