vp_implicit: lowercase hash in whitelist acceptance test#1037
Merged
Conversation
Contributor
Author
|
This fixes it locally, not sure what is up with CI (@Fraccaman?) |
juped
force-pushed
the
ray/fix-whitelist-implicit-test
branch
from
2018ed9 to
b0eee6c
Compare
juped
added a commit
that referenced
this pull request
Jan 17, 2023
* ray/fix-whitelist-implicit-test: changelog: add #1037 vp_implicit: lowercase hash in whitelist acceptance test
Closed
juped
force-pushed
the
ray/fix-whitelist-implicit-test
branch
from
a50ce10 to
4166d37
Compare
tzemanovic
reviewed
Jan 18, 2023
wasm/wasm_source/src/vp_implicit.rs
Outdated
|
|
||
| // hardcoded hash of VP_ALWAYS_TRUE_WASM | ||
| tx_env.init_parameters(None, None, Some(vec!["E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855".to_string()])); | ||
| tx_env.init_parameters(None, None, Some(vec!["E3B0C44298FC1C149AFBF4C8996FB92427AE41E4649B934CA495991B7852B855".to_string().to_lowercase()])); |
Collaborator
There was a problem hiding this comment.
not very important, but we don't need to lowercase here anymore
Contributor
Author
There was a problem hiding this comment.
I will take this lowercasing out as a canary for init_parameters somehow failing to do it.
tzemanovic
previously approved these changes
Jan 18, 2023
juped
force-pushed
the
ray/fix-whitelist-implicit-test
branch
from
4166d37 to
ce53ae3
Compare
juped
added a commit
that referenced
this pull request
Jan 20, 2023
* ray/fix-whitelist-implicit-test: wasm: update checksums.json changelog: add #1037 storage: correct whitelist lowercasing and iteration
bengtlofgren
pushed a commit
that referenced
this pull request
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error introduced by #1018