Skip to content

ci: added build sdk step#2170

Closed
Fraccaman wants to merge 1 commit intomainfrom
fraccaman/ci-here-we-go-again-38
Closed

ci: added build sdk step#2170
Fraccaman wants to merge 1 commit intomainfrom
fraccaman/ci-here-we-go-again-38

Conversation

@Fraccaman
Copy link
Copy Markdown
Collaborator

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman mentioned this pull request Nov 14, 2023
2 tasks
@yito88
Copy link
Copy Markdown
Collaborator

yito88 commented Nov 15, 2023

@Fraccaman Thank you!
I tried it on v0.26.0. Building namada-sdk requires features async-trait and tendermint-rpc (and rand in Cargo.toml of sdk).

	$(cargo) build --package namada_sdk --features tendermint-rpc

Or, should we add async-trait and tendermint-rpc to features' deafult in sdk?

P.S. tendermint-rpc includes async-trait.
I think we should be able to build SDK without any additional features. I've fixed in #2165.

@Fraccaman
Copy link
Copy Markdown
Collaborator Author

@yito88 sounds great!

adrianbrink added a commit that referenced this pull request Nov 15, 2023
#2170)

* origin/fraccaman/ci-here-we-go-again-38:
  ci: added build sdk step
@adrianbrink adrianbrink mentioned this pull request Nov 15, 2023
@tzemanovic
Copy link
Copy Markdown
Collaborator

I think we don't need a new ci step for this - just need to add it to make check-crates (see #2061)

@Fraccaman Fraccaman closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants