Merged
Conversation
tzemanovic
force-pushed
the
tomas/tx-host-env
branch
2 times, most recently
from
197eb5a to
81d440a
Compare
Closed
tzemanovic
added a commit
that referenced
this pull request
Jan 18, 2024
tzemanovic
force-pushed
the
tomas/tx-host-env
branch
from
81d440a to
788e788
Compare
sug0
previously approved these changes
Jan 18, 2024
Collaborator
sug0
left a comment
sug0
left a comment
There was a problem hiding this comment.
some nits and comments. adding proptests to catch panics was a great idea.
tzemanovic
force-pushed
the
tomas/tx-host-env
branch
from
b8ca7af to
23dde75
Compare
sug0
approved these changes
Jan 19, 2024
tzemanovic
added a commit
that referenced
this pull request
Jan 22, 2024
* tomas/tx-host-env: better var names changelog: add #2401 test: test more tx host env fns for panic avoid overflow panic in debug log call host_env: fix vp_result_buffer to handle missing value host_env: fix tx_result_buffer to handle a missing result value test/wasm: checks for panics in tx_read host_env fn
tzemanovic
added a commit
that referenced
this pull request
Jan 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Indicate on which release or other PRs this topic is based on
0.30.1
Checklist before merging to
draft