Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2952 +/- ##
==========================================
- Coverage 53.44% 53.40% -0.05%
==========================================
Files 310 310
Lines 101574 101653 +79
==========================================
- Hits 54288 54287 -1
- Misses 47286 47366 +80 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Mar 25, 2024
Collaborator
|
just needs a changelog for sdk |
tzemanovic
added a commit
that referenced
this pull request
Apr 3, 2024
* origin/fraccaman/sdk-pos: fmt clippy add become_validator to sdk
tzemanovic
added a commit
that referenced
this pull request
Apr 10, 2024
* origin/fraccaman/sdk-pos: fmt clippy add become_validator to sdk # Conflicts: # crates/apps/src/lib/client/tx.rs # crates/sdk/src/tx.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Split
become_validatorlogic into the sdkIndicate on which release or other PRs this topic is based on
Checklist before merging to
draft