Skip to content

Fix enqueued slashes in SM test#3072

Merged
tzemanovic merged 6 commits intomainfrom
brent/fix-sm-test-slashing
Apr 12, 2024
Merged

Fix enqueued slashes in SM test#3072
tzemanovic merged 6 commits intomainfrom
brent/fix-sm-test-slashing

Conversation

@brentstone
Copy link
Copy Markdown
Collaborator

@brentstone brentstone commented Apr 11, 2024

Describe your changes

Make the enqueued slashes in the PoS state machine test compatible with #2574

Indicate on which release or other PRs this topic is based on

#2574

Checklist before merging to draft

  • [ ] I have added a changelog - testing only
  • Git history is in acceptable state

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 56.81400% with 938 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (2ba001d) to head (ef93e25).
Report is 143 commits behind head on main.

❗ Current head ef93e25 differs from pull request most recent head e77da8a. Consider uploading reports for the commit e77da8a to get more accurate results

Files Patch % Lines
crates/apps/src/lib/node/ledger/storage/rocksdb.rs 51.03% 165 Missing ⚠️
crates/apps/src/lib/bench_utils.rs 0.00% 116 Missing ⚠️
crates/core/src/ibc.rs 60.10% 79 Missing ⚠️
crates/apps/src/lib/node/ledger/mod.rs 3.89% 74 Missing ⚠️
...s/apps/src/lib/node/ledger/shell/finalize_block.rs 80.15% 50 Missing ⚠️
crates/apps/src/lib/config/genesis/transactions.rs 24.00% 38 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/governance.rs 46.15% 35 Missing ⚠️
crates/core/src/storage.rs 35.29% 33 Missing ⚠️
...rates/apps/src/lib/node/ledger/shell/init_chain.rs 29.26% 29 Missing ⚠️
...tes/apps/src/lib/node/ledger/shell/testing/node.rs 0.00% 29 Missing ⚠️
... and 45 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3072      +/-   ##
==========================================
+ Coverage   53.88%   59.40%   +5.52%     
==========================================
  Files         308      298      -10     
  Lines      100154    92771    -7383     
==========================================
+ Hits        53966    55110    +1144     
+ Misses      46188    37661    -8527     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone force-pushed the brent/fix-sm-test-slashing branch from b869d34 to ef93e25 Compare April 12, 2024 00:58
@tzemanovic tzemanovic force-pushed the brent/fix-sm-test-slashing branch from ef93e25 to e77da8a Compare April 12, 2024 10:00
@tzemanovic
Copy link
Copy Markdown
Collaborator

rebased onto #2574

@tzemanovic tzemanovic marked this pull request as ready for review April 12, 2024 10:01
@tzemanovic tzemanovic merged commit b0b3a34 into main Apr 12, 2024
@tzemanovic tzemanovic deleted the brent/fix-sm-test-slashing branch April 12, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants