Reformat transfers to a format the hardware wallet already supports.#3418
Reformat transfers to a format the hardware wallet already supports.#3418
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3418 +/- ##
==========================================
- Coverage 53.92% 53.89% -0.03%
==========================================
Files 317 317
Lines 107575 107615 +40
==========================================
- Hits 58011 58001 -10
- Misses 49564 49614 +50 ☔ View full report in Codecov by Sentry. |
tzemanovic
left a comment
There was a problem hiding this comment.
thx for fixing this! Btw, if the rebuild of wasm_for_tests isn't necessary for this change, can we skip it? It makes merging easier as rerere is not very good with binary blobs
|
What's the status here? Is it an issue that this wasn't included in 0.40.0 release? It was never tagged as ready for draft |
This PR was made redundant by #3356 . Closing now, thanks. |
Describe your changes
While splitting the
Transferstructure into 4 case makes sense, hardware wallet support would be simpler to achieve if we left the formatting of the test vectors unchanged. This PR is depended upon by Zondax/ledger-namada#47 .Indicate on which release or other PRs this topic is based on
Namada v0.39.0
Checklist before merging to
draft