Make genesis file based on hardware wallet.#3570
Merged
mergify[bot] merged 8 commits intomainfrom Aug 7, 2024
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3570 +/- ##
=======================================
Coverage 54.55% 54.55%
=======================================
Files 323 323
Lines 113851 113871 +20
=======================================
+ Hits 62106 62118 +12
- Misses 51745 51753 +8 ☔ View full report in Codecov by Sentry. |
tzemanovic
approved these changes
Aug 7, 2024
Contributor
|
Hey @murisi, your pull request has been dequeued due to the following reason: CONFLICT_WITH_BASE_BRANCH. |
52acd7c to
5959d7d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Created an environment variable
NAMADA_E2E_USE_DEVICEto make the end-to-end tests use the hardware wallet for all possible transaction signings. More concretely, this was done as follows:genesis/hardwarefoldergenesis/localnetto ensure the behaviour of E2E tests is not impactedequip will roof matter pink blind book anxiety banner elbow sun young)genesis/hardwaretemplates if theNAMADA_E2E_USE_DEVICEflag is set--use-deviceflag if theNAMADA_E2E_USE_DEVICEflag is setTo successfully use the
NAMADA_E2E_USE_DEVICEenvironment variable, see the instructions at https://github.com/anoma/namada/blob/murisi/hw-e2e/genesis/hardware/README.md#e2e-and-integration-tests .Indicate on which release or other PRs this topic is based on
Namada v0.41.0
Checklist before merging to
draft