Skip to content

Improve the performance of the shielded sync ledger client #4016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 7 commits into from
Nov 12, 2024
Merged

Improve the performance of the shielded sync ledger client #4016

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d5eab16
Move to the previous state of sleep strategy
sug0 Nov 11, 2024
533fa5c
Sleep with the value of the current backoff
sug0 Nov 11, 2024
18848f8
Await on entire fetch to finish
sug0 Nov 12, 2024
2f8c615
Add backoff sleep to ledger client
sug0 Nov 12, 2024
f05d5d9
Disable error messages in shielded sync
sug0 Nov 12, 2024
371db79
Expose block batch size
sug0 Nov 12, 2024
b2332bf
Changelog for #4016
sug0 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Await on entire fetch to finish
  • Loading branch information
@sug0
sug0 committed Nov 12, 2024
commit 18848f86914bd588e0901515d53030a42c0c17d5
6 changes: 2 additions & 4 deletions crates/sdk/src/masp/utilities.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,13 +66,13 @@ impl<C: Client + Send + Sync> MaspClient for LedgerMaspClient<C> {
from: BlockHeight,
to: BlockHeight,
) -> Result<Vec<IndexedNoteEntry>, Error> {
let _permit = self.inner.semaphore.acquire().await.unwrap();

// Fetch all the transactions we do not have yet
let mut txs = vec![];

for height in from.0..=to.0 {
let maybe_txs_results = async {
let _permit = self.inner.semaphore.acquire().await.unwrap();

get_indexed_masp_events_at_height(
&self.inner.client,
height.into(),
Expand All @@ -86,8 +86,6 @@ impl<C: Client + Send + Sync> MaspClient for LedgerMaspClient<C> {
};

let block = {
let _permit = self.inner.semaphore.acquire().await.unwrap();

// Query the actual block to get the txs bytes. If we only need
// one tx it might be slightly better to query
// the /tx endpoint to reduce the amount of data
Expand Down