Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4071 +/- ##
==========================================
+ Coverage 74.32% 74.55% +0.23%
==========================================
Files 341 341
Lines 107401 107399 -2
==========================================
+ Hits 79828 80076 +248
+ Misses 27573 27323 -250 ☔ View full report in Codecov by Sentry. |
grarco
force-pushed
the
grarco/narrow-shielding-retry-logic
branch
from
a268799 to
03b3182
Compare
batconjurer
approved these changes
Nov 26, 2024
grarco
added
the
backport-libs-0.251
3 tasks
grarco
added
merge
mergify bot
added a commit
that referenced
this pull request
Nov 26, 2024
Narrow down shielding retry logic (backport #4071)
tzemanovic
added a commit
that referenced
this pull request
Nov 29, 2024
* maint-0.46: Namada libs 0.46.1 changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Fix `gen_localnet.py` json exception Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46
tzemanovic
added a commit
that referenced
this pull request
Dec 11, 2024
* tomas/ci/test-ledger-app: ci/test-ledger-app: specify container image Point to Ledger app patched to fix decimal point and internal address issue. Format timestamps so that they exactly match hardware wallet outputs. ci: minors Minor simplifications. Added changelog entry. Make the CI run the generated test vectors through the Ledger app unit tests. fix readme links Added a changelog entry. Change the Hermes branch used by the CI. Refactors attaching signatures on wrapper dump ci: run on maint-libs PRs mergify: add apps backport rules, add prefix for libs Hide modified ZIP 32 behind a CLI flag. Downgraded the ledger-namada-rs branch. Now print error messages when MASP hardware wallet integration functionality is triggered. Test that the transfer source now displays as a viewing key. Make the the software wallet support the old Store format. Adjust integration tests to work with both hardware and localnet genesis files. update for mainnet release Namada 1.0.0 clear changelogs released in libs-v0.46.1 changelog: add #4123 Changelog #4120 Removes duplicated `sign-tx` command Adds tests for offline wrapper signature Fixes offline wrapper signature changelog: add #4117 exclude apps crate from libs release apps: don't use workspace version anymore add a script to release apps bins prefix libs release tag with "libs-" mv scripts/release.sh scripts/release_libs.sh add different commit msg for libs release add a different release config for apps Changelog Add a single CometBFT dummy validator Make shielded balance checking more robust for IBC tests. Sometimes use literals instead of aliases in the IBC tests. test/e2e/masp: add support for testing with HW wallet Always sign MASP Transactions before dumping because randomness parameters cannot be reused. Fixed MASP integration tests depending on access to secret keys. fix proposal type Dont do a dry run if using a device in the MASP integration tests. Moved the shielded keys used in the integration tests into the localnet wallet. Never use the hardware wallet to sign the fee header alone. Always ensure removal of MASP Builder data. Separate the storage of shielded keys from their birthdays. Expand MASP hardware wallet support to other transaction types. Factored out the logic for MASP hardware wallet signing. Implemented MASP signing using the hardware wallet. mergify: move autosquash to queue_rules Adds debug trace for masp epochs in asset types Revert "ci(mergify): upgrade configuration to current format" Error match for shielding retry logic Fix `gen_localnet.py` json exception Improves implicit vp display Changelog #4083 Adds missing protocol params in logs Log the implicit vp in `query-protocol-parameters` mergify: backport 0.46 Changelog #4071 Refactors shielding retry logic Shielding retry logic only when masp vp rejects Fix typos in README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #4045.
Ensures that the retry logic for a failed shielding tx hitting an epoch boundary is applied only when the MASP vp is the only one rejecting the tx and the error is among the expected ones.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo