Skip to content

PoS: fix and improve chained redelegation error msg#4264

Merged
mergify[bot] merged 2 commits intomainfrom
tomas/fix-redeleg-err
Jan 22, 2025
Merged

PoS: fix and improve chained redelegation error msg#4264
mergify[bot] merged 2 commits intomainfrom
tomas/fix-redeleg-err

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

Describe your changes

closes #4263

The args for IncomingRedelIsStillSlashable error were swapped. Also added the earliest redelegation epoch to help users determine when they can redelegate again.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic requested a review from brentstone January 22, 2025 12:08
@tzemanovic tzemanovic marked this pull request as ready for review January 22, 2025 12:09
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 74.04%. Comparing base (e36982c) to head (8eca9f8).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/sdk/src/tx.rs 0.00% 16 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4264      +/-   ##
==========================================
- Coverage   74.06%   74.04%   -0.03%     
==========================================
  Files         345      345              
  Lines      109871   109877       +6     
==========================================
- Hits        81372    81354      -18     
- Misses      28499    28523      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Collaborator

@brentstone brentstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx a bunch LGTM

@brentstone brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jan 22, 2025
@mergify mergify bot merged commit c70475b into main Jan 22, 2025
@mergify mergify bot deleted the tomas/fix-redeleg-err branch January 22, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IncomingRedelIsStillSlashable arguments are flipped

2 participants