Skip to content

Make sure the CI installs libudev-dev before building Namada.#4286

Merged
mergify[bot] merged 2 commits intomainfrom
murisi/fix-ci-udev-dep
Feb 3, 2025
Merged

Make sure the CI installs libudev-dev before building Namada.#4286
mergify[bot] merged 2 commits intomainfrom
murisi/fix-ci-udev-dep

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented Jan 31, 2025

Describe your changes

Ensure that libudev-dev is installed by the CI before trying to generate test vectors in test-ledger-app. This addresses the issue that appeared only after merging #4218 . See https://github.com/murisi/namada/actions/runs/13067326899/job/36461810196?pr=2 for a successful run of this fix.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi added the CI label Jan 31, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.03%. Comparing base (1465f26) to head (ae02991).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4286   +/-   ##
=======================================
  Coverage   74.03%   74.03%           
=======================================
  Files         345      345           
  Lines      110047   110047           
=======================================
+ Hits        81476    81478    +2     
+ Misses      28571    28569    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tzemanovic tzemanovic added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass backport-libs-0.251 Backport libraries to 0.251 maintenance branch labels Feb 3, 2025
@mergify mergify bot merged commit b242675 into main Feb 3, 2025
24 of 25 checks passed
@mergify mergify bot deleted the murisi/fix-ci-udev-dep branch February 3, 2025 08:48
mergify bot added a commit that referenced this pull request Feb 3, 2025
Make sure the CI installs libudev-dev before building Namada. (backport #4286)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch CI merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants