Merged
Conversation
3 tasks
c5bc0a6 to
ba4d2c7
Compare
ba4d2c7 to
b9f4594
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4290 +/- ##
==========================================
+ Coverage 74.03% 74.15% +0.11%
==========================================
Files 345 345
Lines 110047 110548 +501
==========================================
+ Hits 81476 81975 +499
- Misses 28571 28573 +2 ☔ View full report in Codecov by Sentry. |
grarco
reviewed
Feb 3, 2025
grarco
approved these changes
Feb 3, 2025
batconjurer
approved these changes
Feb 4, 2025
e229b19 to
73bf957
Compare
3 tasks
mergify bot
added a commit
that referenced
this pull request
Feb 5, 2025
Murisi/remove reverse conversions (backport #4290)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
An alternative to #4288 where the ability to choose the epoch to which amounts are exchanged to is simply removed. This functionality became redundant once pinned transactions were removed in #3142 . More generally, this functionality is only needed for properly implementing functionality like account statements and pinned transactions where the amounts that were received need to be printed out exactly as they were in the past without any influence from conversions in the current tree.
Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo