Skip to content

Murisi/remove reverse conversions#4290

Merged
mergify[bot] merged 9 commits intomainfrom
murisi/remove-reverse-conversions
Feb 5, 2025
Merged

Murisi/remove reverse conversions#4290
mergify[bot] merged 9 commits intomainfrom
murisi/remove-reverse-conversions

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented Jan 31, 2025

Describe your changes

An alternative to #4288 where the ability to choose the epoch to which amounts are exchanged to is simply removed. This functionality became redundant once pinned transactions were removed in #3142 . More generally, this functionality is only needed for properly implementing functionality like account statements and pinned transactions where the amounts that were received need to be printed out exactly as they were in the past without any influence from conversions in the current tree.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi mentioned this pull request Jan 31, 2025
3 tasks
@murisi murisi force-pushed the murisi/remove-reverse-conversions branch from c5bc0a6 to ba4d2c7 Compare February 3, 2025 08:50
@murisi murisi force-pushed the murisi/remove-reverse-conversions branch from ba4d2c7 to b9f4594 Compare February 3, 2025 09:15
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 98.41270% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.15%. Comparing base (1465f26) to head (73bf957).
Report is 85 commits behind head on main.

Files with missing lines Patch % Lines
crates/core/src/masp.rs 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4290      +/-   ##
==========================================
+ Coverage   74.03%   74.15%   +0.11%     
==========================================
  Files         345      345              
  Lines      110047   110548     +501     
==========================================
+ Hits        81476    81975     +499     
- Misses      28571    28573       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@murisi murisi requested review from batconjurer, grarco and sug0 February 3, 2025 10:19
@murisi murisi force-pushed the murisi/remove-reverse-conversions branch from e229b19 to 73bf957 Compare February 5, 2025 05:15
@murisi murisi added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Feb 5, 2025
mergify bot added a commit that referenced this pull request Feb 5, 2025
@mergify mergify bot merged commit aef9efc into main Feb 5, 2025
25 checks passed
@mergify mergify bot deleted the murisi/remove-reverse-conversions branch February 5, 2025 07:26
@tzemanovic tzemanovic added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Feb 5, 2025
mergify bot added a commit that referenced this pull request Feb 5, 2025
Murisi/remove reverse conversions (backport #4290)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants