Skip to content

Slow down the epochs in tricky_masp_txs.#4631

Merged
mergify[bot] merged 2 commits intomainfrom
murisi/fix-flaky-tricky_masp_txs
May 8, 2025
Merged

Slow down the epochs in tricky_masp_txs.#4631
mergify[bot] merged 2 commits intomainfrom
murisi/fix-flaky-tricky_masp_txs

Conversation

@murisi
Copy link
Copy Markdown
Collaborator

@murisi murisi commented May 7, 2025

Describe your changes

The tricky_masp_txs integration test sometimes fails because the epoch transitions happen too quickly. This causes Transactions to be rejected because their asset types are outdated at their time of application. This PR slows down the epochs in tricky_masp_txs to make sure that this doesn't happen.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@murisi murisi requested a review from tzemanovic May 7, 2025 15:03
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label May 7, 2025
@tzemanovic tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label May 8, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c2cddf3) to head (99353cb).
Report is 15 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4631   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot merged commit 232b011 into main May 8, 2025
28 checks passed
@mergify mergify bot deleted the murisi/fix-flaky-tricky_masp_txs branch May 8, 2025 15:33
mergify bot added a commit that referenced this pull request Jun 2, 2025
Slow down the epochs in tricky_masp_txs. (backport #4631)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch MASP merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants