Skip to content

Conversation

@shrugs
Copy link
Collaborator

@shrugs shrugs commented Jun 24, 2025

closes #731

  • renamed ACTIVE_PLUGINS to PLUGINS
  • kept 'active plugins' terminology within comments and variable names when the set of plugins is indeed the filtered set of active plugins
  • also keeping 'Active Plugins' in ENSAdmin labels for explicitness

@shrugs shrugs requested a review from a team as a code owner June 24, 2025 11:41
@changeset-bot
Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: 844cd3a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
ensindexer Minor
ensadmin Minor
ensrainbow Minor
@ensnode/datasources Minor
@ensnode/ensrainbow-sdk Minor
@ensnode/ponder-metadata Minor
@ensnode/ensnode-schema Minor
@ensnode/ponder-subgraph Minor
@ensnode/ensnode-sdk Minor
@ensnode/shared-configs Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jun 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
admin.ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 1:26pm
ensnode.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 1:26pm
ensrainbow.io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 24, 2025 1:26pm

Copy link
Contributor

@tk-o tk-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lightwalker-eth lightwalker-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shrugs Nice! Looks good 👍 Shared a tiny suggestion. Please merge when ready

@shrugs shrugs merged commit 1f29c5d into main Jun 24, 2025
5 of 7 checks passed
@shrugs shrugs deleted the fix/plugins-config-var branch June 24, 2025 13:23
@github-actions github-actions bot mentioned this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename ACTIVE_PLUGINS env var to PLUGINS

4 participants