Skip to content

Should set UnderlyingType when use Template - #429

Merged
natemcmaster merged 1 commit into
natemcmaster:mainfrom
scott-xu:underlying_type_fix
Jan 20, 2021
Merged

Should set UnderlyingType when use Template#429
natemcmaster merged 1 commit into
natemcmaster:mainfrom
scott-xu:underlying_type_fix

Conversation

@scott-xu

Copy link
Copy Markdown
Contributor

The UnderlyingType was null if use Template. For enum option, If UnderlyingType is null, the help text generator will not add the default values text. This PR fixes the issue.

@codecov

codecov Bot commented Jan 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #429 (c48ffbc) into main (5655d03) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   82.00%   82.00%           
=======================================
  Files         106      106           
  Lines        3284     3284           
=======================================
  Hits         2693     2693           
  Misses        591      591           
Impacted Files Coverage Δ
src/CommandLineUtils/Attributes/OptionAttribute.cs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85059ba...c48ffbc. Read the comment docs.

@natemcmaster natemcmaster left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scott-xu !

@natemcmaster
natemcmaster merged commit 1d6e1a5 into natemcmaster:main Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants