Skip to content

fix: handle non-utf8 bytes in log parser#68

Merged
nathanbabcock merged 1 commit intomainfrom
fix/non-utf8
Dec 5, 2024
Merged

fix: handle non-utf8 bytes in log parser#68
nathanbabcock merged 1 commit intomainfrom
fix/non-utf8

Conversation

@nathanbabcock
Copy link
Owner

Fixes #67

Switch from_utf8 to from_utf8_lossy. Instead of throwing an error when encountering invalid characters, it will insert placeholder error characters instead, e.g.: Apple �T�E���h�E���f�B�A�n���h��.

To try this fix immediately, run this command to add the bugfix branch as a dependency:

cargo add ffmpeg-sidecar --git https://github.com/nathanbabcock/ffmpeg-sidecar.git --branch fix/non-utf8

@nathanbabcock
Copy link
Owner Author

CI failure is an unrelated Github Actions issue with DNS resolution on Mac M1, I will try it again later.

0: https://www.osxexperts.net/ffmpeg7arm.zip: Dns Failed: resolve dns name 'www.osxexperts.net:443': failed to lookup address information

@nathanbabcock nathanbabcock merged commit cc0349e into main Dec 5, 2024
@nathanbabcock nathanbabcock deleted the fix/non-utf8 branch December 5, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Garbled output from FFmpeg caused an FFmpeg-sidecar panic

1 participant