Skip to content

Fix for flaky tests #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpsfrishberg merged 2 commits into from
Jun 2, 2015
Merged

Fix for flaky tests #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e613da0
Hiding the element for wait_till_not_visible instead of removing it
dpsfrishberg Apr 24, 2015
22b2e53
Replacing checks for existence of element with checks for visibility
dpsfrishberg Jun 2, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/scenarios/po/selectors_page.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ class Page(RobotPage):
selectors = {
"search-button": "css=#go",
"inputs": "css=input",
"remove-button": "css=button#remove-content",
"para-to-be-removed": "css=p#disappear",
"hide-button": "css=button#hide-content",
"para-to-be-hidden": "css=p#disappear",
"delayed-content-button":"css=button#delayed-content"
}
10 changes: 5 additions & 5 deletions tests/scenarios/site/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ <h1>Your source for great widgets</h1>
</div>

<br><hr>
<div class="ct-to-be-removed">
<p id="disappear">I am another paragraph added to test remove button</p>
<div class="ct-to-be-hidden">
<p id="disappear">I am another paragraph added to test hide button</p>
</div>
<button id="remove-content">Click to remove content</button>
<button id="hide-content">Click to hide content</button>


</form>
Expand Down Expand Up @@ -63,10 +63,10 @@ <h1>Your source for great widgets</h1>
});

// clicking on remove me button removes the delayed content
jQuery("#remove-content").click( function(e) {
jQuery("#hide-content").click( function(e) {
e.preventDefault();
setTimeout( function() {
jQuery(".ct-to-be-removed").remove();
jQuery(".ct-to-be-hidden").hide();
}, 5000);
});

Expand Down
16 changes: 8 additions & 8 deletions tests/scenarios/test_wait_until_not_visible.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,27 +8,27 @@ def setUp(self):
self.p.open()

def test_wait_until_element_not_visible(self):
self.p.click_element("remove-button")
self.p.wait_until_element_is_not_visible("para-to-be-removed")
self.p.page_should_not_contain_element("para-to-be-removed")
self.p.click_element("hide-button")
self.p.wait_until_element_is_not_visible("para-to-be-hidden")
self.p.element_should_not_be_visible("para-to-be-hidden")

def test_wait_for_element_not_visible(self):
self.p.click_element("remove-button")
self.p.wait_for(lambda: not self.p.is_visible("para-to-be-removed"))
self.p.page_should_not_contain_element("para-to-be-removed")
self.p.click_element("hide-button")
self.p.wait_for(lambda: not self.p.is_visible("para-to-be-hidden"))
self.p.element_should_not_be_visible("para-to-be-hidden")

def test_wait_until_element_not_visible_throws_exception(self):
try:
self.p.click_element("delayed-content-button")
self.p.wait_until_element_is_not_visible("para-to-be-removed", 8)
self.p.wait_until_element_is_not_visible("para-to-be-hidden", 8)
except Exception, e:
self.assertTrue(isinstance(e, AssertionError))
self.assertIn("still matched after", e.message)

def test_wait_for_element_not_visible_throws_exception(self):
try:
self.p.click_element("delayed-content-button")
self.p.wait_for(lambda: not self.p.is_visible("para-to-be-removed"), 8, 'Element did not disappear')
self.p.wait_for(lambda: not self.p.is_visible("para-to-be-hidden"), 8, 'Element did not disappear')
except Exception, e:
self.assertIn("Element did not disappear", e.msg)

Expand Down