Skip to content

Build cross-platform binaries with Docker#41

Closed
shinsenter wants to merge 1 commit into
ncopa:masterfrom
shinsenter:master
Closed

Build cross-platform binaries with Docker#41
shinsenter wants to merge 1 commit into
ncopa:masterfrom
shinsenter:master

Conversation

@shinsenter
Copy link
Copy Markdown

@shinsenter shinsenter commented Aug 19, 2025

@tianon
Copy link
Copy Markdown
Contributor

tianon commented Aug 19, 2025

This doesn't really have anything to do with #23 ? 🤔

Can you elaborate?

@shinsenter
Copy link
Copy Markdown
Author

@tianon
Actually I didn't really modify much in the su-exec.c file.
It was taken from another fork, which claims to have fixed a critical bug from this repo. Please refer to it.
I will update the title of this pull request.

@shinsenter shinsenter changed the title Fix #23; build binaries for multiple platforms using Docker Build cross-platform binaries with Docker Aug 19, 2025
@tianon
Copy link
Copy Markdown
Contributor

tianon commented Aug 19, 2025

The so-called "critical bug" was fixed upstream in #26 - all that's missing is a release (no further code changes required).

@shinsenter
Copy link
Copy Markdown
Author

@tianon
Sorry about that, I'm not familiar with C.

I've updated the title, and I can revert su-exec.c and Makefile to the original files if you consider the focus of this pull request to be building cross-platform binaries for multiple distros using Docker.

Or just close this pull request, and I'll maintain the binaries and Docker images in my own repository.

Best regards

@tianon
Copy link
Copy Markdown
Contributor

tianon commented Aug 19, 2025

Sorry, let me be clear: I'm not the maintainer here, just an interested party. 👍

@shinsenter
Copy link
Copy Markdown
Author

Oh, my bad.

I think I'll close this pull request myself, as it doesn't seem to bring much benefit to the su-exec community.

Thank you!

@shinsenter shinsenter closed this Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

⚠️DANGER: Vulnerable by design! (on any system supporting TIOCSTI, such as Linux)

2 participants