Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

View state#684

Merged
vgrichina merged 5 commits intomasterfrom
view-state
Apr 1, 2021
Merged

View state#684
vgrichina merged 5 commits intomasterfrom
view-state

Conversation

@vgrichina
Copy link
Contributor

No description provided.

@vgrichina vgrichina requested a review from volovyks March 3, 2021 02:39
@volovyks volovyks self-requested a review March 3, 2021 12:51
const { formatResponse } = require('../utils/inspect-response');

module.exports = {
command: 'view-state <account-id> [prefix]',
Copy link
Collaborator

@volovyks volovyks Mar 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Semantically it's the same as state. Should we rename it to view-contract-state, or simply contract-state? @mikedotexe @evgenykuzyakov @chadoh need your opinion here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once we have the namespaces proposed in near/NEPs#31, I would advocate for near contract state. But I doubt it makes sense to do that for now.

In the meantime, I don't have a strong preference. near view-state some-contract.near seems fine to me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll just roll as is then and makes sense to me to change to namespaces long term.

@vgrichina vgrichina marked this pull request as ready for review April 1, 2021 07:29
@vgrichina vgrichina merged commit fcba8d0 into master Apr 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants