Add the NeoForgedRepositoryFilter to address the issues associated with NeoForge Maven using the Maven Central repository#329
Open
Gu-ZT wants to merge 1 commit intoneoforged:mainfrom
Open
Conversation
Gu-ZT
commented
Mar 19, 2026
Gu-ZT
commented
- fixed Neoforged Maven Central Mirror Missing interfaceinjection.json Artifacts #327
|
There was a problem hiding this comment.
Pull request overview
Adds a repository content filter for the NeoForged Releases Maven repo to prevent it from behaving like a partial Maven Central mirror and blocking fallback resolution of missing artifacts (e.g., *-interfaceinjection.json), addressing issue #327.
Changes:
- Apply a content allowlist (
NeoForgedRepositoryFilter) to thehttps://maven.neoforged.net/releases/repository. - Introduce a generated allowlist class enumerating the allowed modules for the NeoForged Releases repository.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/main/java/net/neoforged/moddevgradle/internal/RepositoriesPlugin.java |
Applies the new NeoForged repository content filter to the NeoForged Releases repo. |
src/generated/java/net/neoforged/moddevgradle/internal/generated/NeoForgedRepositoryFilter.java |
New allowlist used to constrain which coordinates may resolve from the NeoForged Releases repo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…th NeoForge Maven using the Maven Central repository
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.