perf: reduce bundle size by 34% (35MB → 23MB)#262
Merged
Conversation
Two optimizations: 1. Deduplicate shiki across @pierre/diffs (shiki@3) and app (shiki@4) via resolve.dedupe, eliminating 232 duplicate language/theme grammar chunks. 2. Resize PNG app icons from 1024-1646px to 64x64 (displayed at 16x16 CSS).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve.dedupe: ["shiki"]in electron-vite config —@pierre/diffs(shiki@3) and the app (shiki@4) were each bundling their own copy of all 230+ language grammars and 65+ themes, producing 232 byte-identical duplicate chunks. This eliminates ~9 MB of JS.size-4(16×16 CSS / 32×32 Retina), so 64px provides 4× coverage. Saves ~1.7 MB.Test plan
bun readypasses (format + typecheck + lint + 261 tests)