Skip to content

Rename train_split_percentage with train_split_fraction#1497

Merged
tancik merged 1 commit intonerfstudio-project:mainfrom
97littleleaf11:rename-train-split-percentage
Feb 24, 2023
Merged

Rename train_split_percentage with train_split_fraction#1497
tancik merged 1 commit intonerfstudio-project:mainfrom
97littleleaf11:rename-train-split-percentage

Conversation

@97littleleaf11
Copy link
Copy Markdown
Contributor

Closes #1411

Copy link
Copy Markdown
Contributor

@tancik tancik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tancik tancik merged commit e0ad537 into nerfstudio-project:main Feb 24, 2023
@97littleleaf11 97littleleaf11 deleted the rename-train-split-percentage branch February 24, 2023 19:24
jkulhanek pushed a commit to jkulhanek/nerfstudio that referenced this pull request Feb 27, 2023
f-dy pushed a commit to f-dy/sdfstudio that referenced this pull request Apr 20, 2023
- See nerfstudio-project/nerfstudio#1543
- Also default to "vertical" which works better than "up" (nerfstudio-project/nerfstudio#1765)
- Also rename train_split_percentage to train_split_fraction (nerfstudio-project/nerfstudio#1497)
chris838 pushed a commit to chris838/nerfstudio that referenced this pull request Apr 22, 2023
…roject#1497)

rename train_split_percentage with train_split_fraction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename train_split_percentage to train_split_fraction?

2 participants