Skip to content

chore: Delete inline eslint comments(rules) #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashchan merged 1 commit into from
Oct 28, 2019
Merged

chore: Delete inline eslint comments(rules) #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/neuron-wallet/src/listeners/tx-status.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,6 @@ const getTransactionStatus = async (hash: string) => {
}
}

/* eslint no-await-in-loop: "off" */
/* eslint no-restricted-syntax: "off" */
const trackingStatus = async () => {
const pendingTransactions = await FailedTransaction.pendings()
if (!pendingTransactions.length) {
Expand Down
2 changes: 0 additions & 2 deletions packages/neuron-wallet/src/services/addresses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,6 @@ export default class AddressService {
)
}

/* eslint no-await-in-loop: "off" */
/* eslint no-restricted-syntax: "off" */
public static updateTxCountAndBalances = async (
addresses: string[],
url: string = NodeService.getInstance().core.rpc.node.url
Expand Down
2 changes: 0 additions & 2 deletions packages/neuron-wallet/src/services/sync/block-listener.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ export default class BlockListener {
})
}

/* eslint no-await-in-loop: "off" */
/* eslint no-restricted-syntax: "off" */
public setToTip = async () => {
const timeout = 5000
let number: bigint = BigInt(0)
Expand Down
2 changes: 0 additions & 2 deletions packages/neuron-wallet/src/services/sync/check-and-save/tx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,6 @@ export default class CheckTx {
return cells
}

/* eslint no-await-in-loop: "off" */
/* eslint no-restricted-syntax: "warn" */
public filterInputs = async (lockHashes: string[]): Promise<string[]> => {
const inputs = this.tx.inputs!

Expand Down
1 change: 0 additions & 1 deletion packages/neuron-wallet/src/services/sync/queue.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ export default class Queue {
this.lockHashes = lockHashes
}

/* eslint no-await-in-loop: "off" */
public start = async () => {
while (!this.stopped) {
try {
Expand Down
2 changes: 0 additions & 2 deletions packages/neuron-wallet/src/services/sync/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default class Utils {
return new Promise(resolve => setTimeout(resolve, ms))
}

/* eslint no-await-in-loop: "off" */
public static retry = async (times: number, interval: number, callback: any): Promise<any> => {
let retryTime = 0

Expand All @@ -39,7 +38,6 @@ export default class Utils {
return undefined
}

/* eslint no-restricted-syntax: "off" */
public static mapSeries = async (array: any[], callback: any): Promise<any[]> => {
const result = []
for (const item of array) {
Expand Down
1 change: 0 additions & 1 deletion packages/neuron-wallet/src/startup/sync-block-task/create.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ const loadURL = `file://${path.join(__dirname, 'index.html')}`

export { networkSwitchSubject }

/* eslint global-require: "off" */
// create a background task to sync transactions
// this task is a renderer process
const createSyncBlockTask = () => {
Expand Down