Optimize non indexer sync - #1027
Merged
Merged
Conversation
This optimizes particularly for our test purpose batch txs, which send a few hundreds from and to the same address.
classicalliu
approved these changes
Oct 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local optimization for batch txs from and to the same address.
For each block, simply add a hash map to cache the output tx used by input.
This speeds up tx insert for our batch txs test (e.g. https://explorer.nervos.org/transaction/0x774a3e608afe267617d28db098dd9e36c93df9de75aedf10d8e5fcb55e38e774) from 2-5 txs/sec to 50~ txs/sec.
Note for a real world block that contains many unrelated transactions this optimization won't help. We still need to figure out how to tweak that. But for end user usage I don't think a wallet would have so many transactions.