Skip to content

feat: update the address prefix and the explorer url according to the chain type - #1065

Merged
ashchan merged 4 commits into
developfrom
testnet-explorer-url
Nov 11, 2019
Merged

feat: update the address prefix and the explorer url according to the chain type#1065
ashchan merged 4 commits into
developfrom
testnet-explorer-url

Conversation

@ashchan

@ashchan ashchan commented Nov 9, 2019

Copy link
Copy Markdown
Contributor

TODO

  • isMainnet pending implementation.

@ashchan
ashchan requested a review from Keith-CY November 9, 2019 11:24
@ashchan ashchan changed the title feat: Finalize testnet explorer URL [HOLD]feat: Finalize testnet explorer URL Nov 9, 2019
nervos-bot[bot]
nervos-bot Bot previously requested changes Nov 9, 2019

@nervos-bot nervos-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold as requested by @ashchan.

@Keith-CY
Keith-CY requested review from Keith-CY and classicalliu and removed request for Keith-CY and classicalliu November 10, 2019 05:56
@Keith-CY

Copy link
Copy Markdown
Contributor

Updated

@Keith-CY Keith-CY changed the title [HOLD]feat: Finalize testnet explorer URL [HOLD]feat: update the address prefix and the explorer url according to the chain type Nov 10, 2019
@ashchan ashchan changed the title [HOLD]feat: update the address prefix and the explorer url according to the chain type feat: update the address prefix and the explorer url according to the chain type Nov 10, 2019
@nervos-bot
nervos-bot Bot dismissed their stale review November 10, 2019 07:36

Unhold as requested by @ashchan.

@ashchan
ashchan requested a review from classicalliu November 10, 2019 07:36
@ashchan
ashchan merged commit 3b5545e into develop Nov 11, 2019
@ashchan
ashchan deleted the testnet-explorer-url branch November 11, 2019 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants