Skip to content

feat: Multisig import and export config compatible with ckb-cli - #2442

Merged
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:feat-compatible-multisig-ckbcli
Jul 18, 2022
Merged

feat: Multisig import and export config compatible with ckb-cli#2442
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:feat-compatible-multisig-ckbcli

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

Multisig config created by ckb-cli can also import by Neuron.

adapt-ckb-cli.mov

Comment thread packages/neuron-wallet/src/controllers/multisig.ts Outdated
@yanguoyu
yanguoyu force-pushed the feat-compatible-multisig-ckbcli branch from bf56388 to 8603fb7 Compare July 15, 2022 04:23
Comment thread packages/neuron-wallet/src/controllers/multisig.ts Outdated
Comment thread packages/neuron-wallet/src/controllers/multisig.ts Outdated

@Cedar67 Cedar67 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Import the multisig address file generated by the CKB CLI for the first time.
✅ Import the multisig address file generated by the CKB CLI repeatedly.
✅ Import a [1 of 2] multisig address file generated by the CKB CLI.
✅ Import a [2 of 2] multisig address file generated by the CKB CLI.
✅ View the multisig address file generated by CKB CLI in Neuron.
✅ Export the multisig address file generated by the CKB CLI.
✅ Transation is performed by Neuron through the multisig address generated by CKB CLI.
✅ Approvement is performed by Neuron through the multisig address generated by CKB CLI.

@Keith-CY
Keith-CY merged commit 9b9287a into nervosnetwork:develop Jul 18, 2022
@yanguoyu
yanguoyu deleted the feat-compatible-multisig-ckbcli branch July 18, 2022 02:39
@Keith-CY Keith-CY mentioned this pull request Sep 2, 2022
@Keith-CY Keith-CY mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants