feat: Multisig import and export config compatible with ckb-cli - #2442
Merged
Keith-CY merged 5 commits intoJul 18, 2022
Merged
Conversation
Keith-CY
reviewed
Jul 11, 2022
yanguoyu
force-pushed
the
feat-compatible-multisig-ckbcli
branch
from
July 14, 2022 08:17
4ac6d12 to
bf56388
Compare
yanguoyu
force-pushed
the
feat-compatible-multisig-ckbcli
branch
from
July 15, 2022 04:23
bf56388 to
8603fb7
Compare
Keith-CY
reviewed
Jul 15, 2022
Keith-CY
approved these changes
Jul 15, 2022
Cedar67
approved these changes
Jul 18, 2022
Cedar67
left a comment
Contributor
There was a problem hiding this comment.
✅ Import the multisig address file generated by the CKB CLI for the first time.
✅ Import the multisig address file generated by the CKB CLI repeatedly.
✅ Import a [1 of 2] multisig address file generated by the CKB CLI.
✅ Import a [2 of 2] multisig address file generated by the CKB CLI.
✅ View the multisig address file generated by CKB CLI in Neuron.
✅ Export the multisig address file generated by the CKB CLI.
✅ Transation is performed by Neuron through the multisig address generated by CKB CLI.
✅ Approvement is performed by Neuron through the multisig address generated by CKB CLI.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multisig config created by ckb-cli can also import by Neuron.
adapt-ckb-cli.mov