Skip to content

fix: Fix send multisig tx when input cell's length is more than 1. - #2450

Merged
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:fix-group-cell-witness-0x
Jul 15, 2022
Merged

fix: Fix send multisig tx when input cell's length is more than 1.#2450
Keith-CY merged 5 commits into
nervosnetwork:developfrom
yanguoyu:fix-group-cell-witness-0x

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor

No description provided.

@yanguoyu

Copy link
Copy Markdown
Contributor Author

If some unexpected error happens, it should display. 88fb8d1

image

@yanguoyu
yanguoyu force-pushed the fix-group-cell-witness-0x branch from d0303f4 to 3d8ff5a Compare July 15, 2022 06:29
yanguoyu added 2 commits July 15, 2022 14:34
same group cell witness should be 0x. If witness's lock set as 0x. it will be serialized that not equal 0x
@yanguoyu
yanguoyu force-pushed the fix-group-cell-witness-0x branch from 3d8ff5a to 14ebf17 Compare July 15, 2022 06:40
@yanguoyu yanguoyu changed the title fix: Same group cell witness should be 0x. If witness's lock set as 0x. it will be serialized that not equal 0x fix: Fix send multisig tx when input cell's length is more than 1. Jul 15, 2022

@Cedar67 Cedar67 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scenario has been verified:
When the sender has multiple input cells, the transaction is expected.

@Keith-CY
Keith-CY merged commit ce2c08f into nervosnetwork:develop Jul 15, 2022
@yanguoyu
yanguoyu deleted the fix-group-cell-witness-0x branch July 18, 2022 02:40
@Keith-CY Keith-CY mentioned this pull request Sep 2, 2022
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Dec 21, 2022
…ervosnetwork#2450)

* fix: Same group cell witness should be 0x. If witness's lock set as 0x. it will be serialized that not equal 0x

* fix: If some unexpected error happen, it should display

* fix: Fix send multisig tx when input cell's length is more than 1.

same group cell witness should be 0x. If witness's lock set as 0x. it will be serialized that not equal 0x

* fix: If some unexpected error happen, it should display

Co-authored-by: Cedar <cedarfortest@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants