Skip to content

feat: Create new wallet for new ui - #2463

Merged
yanguoyu merged 10 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:new-ui-create-wallet
Sep 22, 2022
Merged

feat: Create new wallet for new ui#2463
yanguoyu merged 10 commits into
nervosnetwork:new-ui-designfrom
yanguoyu:new-ui-create-wallet

Conversation

@yanguoyu

@yanguoyu yanguoyu commented Aug 5, 2022

Copy link
Copy Markdown
Contributor

For light theme:

  1. Create a wallet with a new mnemonic
create-by-new-mn-light.mov
  1. Create a wallet by Keystore file
create-by-ks-light.mov
  1. Create a wallet with existing mnemonic
create-by-mene-light.mov
  1. Create a hard wallet
create-by-hardwallet-light.mov

For dark theme:

  1. Create a wallet with a new mnemonic
create-by-new-mn.mov
  1. Create a wallet by Keystore file
create-by-ks.mov
  1. Create a wallet with existing mnemonic
create-by-mene.mov
  1. Create a hard wallet
create-by-hardwallet.mov

Comment thread packages/neuron-ui/src/components/ImportHardware/detect-device.tsx Outdated
Comment thread packages/neuron-ui/src/components/ImportHardware/index.tsx
Comment thread packages/neuron-ui/src/components/ImportHardware/index.tsx Outdated
Comment thread packages/neuron-ui/src/components/ImportHardware/name-wallet.tsx Outdated
Comment thread packages/neuron-ui/src/components/ImportHardware/common.ts
Comment thread packages/neuron-ui/src/widgets/Button/index.tsx
Comment thread packages/neuron-ui/src/widgets/MnemonicInput/index.module.scss Outdated
Comment thread packages/neuron-ui/src/widgets/MnemonicInput/index.tsx Outdated
Comment thread packages/neuron-ui/src/widgets/MnemonicInput/index.tsx Outdated
Comment thread packages/neuron-ui/src/widgets/TextField/textField.module.scss Outdated
Comment thread packages/neuron-ui/src/locales/en.json Outdated
Comment thread packages/neuron-ui/src/locales/zh-tw.json Outdated
Comment thread packages/neuron-ui/src/locales/zh.json Outdated
@Keith-CY

Copy link
Copy Markdown
Contributor

CI failed

@Cedar67

Cedar67 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

On the Mnemonic words display page, there are 2 UI displays (As shown in the figure below) that need to be confirmed.

image

@Cedar67

Cedar67 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

On the page for setting a password, there are 2 UI displays (As shown in the figure below) that need to be confirmed.

image

@Cedar67

Cedar67 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

On the page for setting a password, displaying passwords is required.

image

@Cedar67

Cedar67 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

On the page for importing mnemonic words, when enter the wrong mnemonic word and click Next, the system prompt box is thrown. About the pop window,is there a need to improve the UI here?

image

Magickbase/neuron-public-issues#46 (comment)

@Cedar67

Cedar67 commented Aug 30, 2022

Copy link
Copy Markdown
Contributor

The prompt for Keystore file format verification needs to be adjusted.

image

@Cedar67

Cedar67 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

On the page for Import Keystore file, displaying passwords is required.

image

@Cedar67

Cedar67 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

On the page for Selecting a Device Model, the selected option font color needs to be green.

image

@Cedar67

Cedar67 commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

On the Search Device page, there are 2 UI displays (As shown in the figure below) that need to be adjusted.

image

@yanguoyu

yanguoyu commented Sep 2, 2022

Copy link
Copy Markdown
Contributor Author

Magickbase/visual-style-guide#2 (comment)
Except for special fonts, use system fonts. So sometimes win and mac show different.

@Cedar67

Cedar67 commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

When creating a hardware wallet, empty wallet name should not be allowed.

image

@Cedar67

Cedar67 commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

When creating a hardware wallet, the wallet name should be limited to 20 characters, and a prompt is required when it exceeds 20 characters.

image

@yanguoyu
yanguoyu requested a review from Keith-CY September 5, 2022 14:17
@yanguoyu

yanguoyu commented Sep 5, 2022

Copy link
Copy Markdown
Contributor Author

Fixed

@Cedar67

Cedar67 commented Sep 13, 2022

Copy link
Copy Markdown
Contributor

On the page for Import Keystore file, when the input JSON file format is abnormal, the message language is not the expected Chinese.

image

@yanguoyu

Copy link
Copy Markdown
Contributor Author

On the page for Import Keystore file, when the input JSON file format is abnormal, the message language is not the expected Chinese.

image

Check import JSON file has required fields fixed.

@Cedar67

Cedar67 commented Sep 14, 2022

Copy link
Copy Markdown
Contributor

Fixed

On the page for Import Keystore file, when the input JSON file format is abnormal, the message language is not the expected Chinese.
image

Check import JSON file has required fields fixed.

Verified.

Comment thread packages/neuron-ui/src/widgets/Alert/index.tsx Outdated
Comment thread packages/neuron-ui/src/widgets/TextField/index.tsx
@Keith-CY

Copy link
Copy Markdown
Contributor

This PR could be squash-merged at any time you prefer @yanguoyu

@yanguoyu

Copy link
Copy Markdown
Contributor Author

This PR could be squash-merged at any time you prefer @yanguoyu

Should we merge develop into new-ui-design first?

@Keith-CY

Copy link
Copy Markdown
Contributor

This PR could be squash-merged at any time you prefer @yanguoyu

Should we merge develop into new-ui-design first?

Sure, we can merge develop into new-ui-design first

1. Add end-line for file.
2. Use themeSource and prefers-color-scheme for theme.
3. Better variable name.
@yanguoyu
yanguoyu force-pushed the new-ui-create-wallet branch from d21a911 to c71e6fa Compare September 16, 2022 11:12
@yanguoyu
yanguoyu merged commit 857f8e3 into nervosnetwork:new-ui-design Sep 22, 2022
@yanguoyu
yanguoyu deleted the new-ui-create-wallet branch September 22, 2022 08:28
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Sep 28, 2022
* feat: Create a new wallet for new UI
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Sep 28, 2022
* feat: Create a new wallet for new UI
@yanguoyu
yanguoyu restored the new-ui-create-wallet branch October 21, 2022 08:51
@yanguoyu
yanguoyu deleted the new-ui-create-wallet branch October 21, 2022 08:52
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Oct 23, 2022
* feat: Create a new wallet for new UI
yanguoyu added a commit that referenced this pull request Oct 23, 2022
* feat: Create a new wallet for new UI
yanguoyu added a commit to yanguoyu/neuron that referenced this pull request Mar 10, 2023
* feat: Create a new wallet for new UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants