Skip to content

fix: Fix some exception from set ckb node path - #2478

Merged
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-empty-ckb-path
Aug 30, 2022
Merged

fix: Fix some exception from set ckb node path#2478
Keith-CY merged 1 commit into
nervosnetwork:developfrom
yanguoyu:fix-empty-ckb-path

Conversation

@yanguoyu

Copy link
Copy Markdown
Contributor
  1. Set ckb node data path to an empty directory, always delete mainnet ckb indexer data.
  2. Delete ckb indexer data after start ckb to ensure ckb indexer data directory is correctly.

1. Set ckb node data path to an empty directory, always delete mainnet ckb indexer data.
2. Delete ckb indexer data after start ckb to ensure ckb indexer data directory is correctly.
@Cedar67

Cedar67 commented Aug 29, 2022

Copy link
Copy Markdown
Contributor
  1. Set ckb node data path to an empty directory, always delete mainnet ckb indexer data.
  2. Delete ckb indexer data after start ckb to ensure ckb indexer data directory is correctly.

Verified.

@Cedar67

Cedar67 commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Unexpected:
After manually started CKB nodes are stopped, Neuron cannot start internal CKB nodes normally.

20220829-120540-HD.mov

image

@yanguoyu

Copy link
Copy Markdown
Contributor Author

Unexpected: After manually started CKB nodes are stopped, Neuron cannot start internal CKB nodes normally.

20220829-120540-HD.mov
image

Upload bundled-ckb.log to help me why the ckb node stopped.

@Cedar67

Cedar67 commented Aug 29, 2022

Copy link
Copy Markdown
Contributor

Unexpected: After manually started CKB nodes are stopped, Neuron cannot start internal CKB nodes normally.
20220829-120540-HD.mov
image

Upload bundled-ckb.log to help me why the ckb node stopped.

@yanguoyu FYI
neuron_debug_1661744320528.zip

@yanguoyu

Copy link
Copy Markdown
Contributor Author

image

Maybe your ckb node is not completely stopped

@Cedar67

Cedar67 commented Aug 29, 2022

Copy link
Copy Markdown
Contributor
image

Maybe your ckb node is not completely stopped.

Looks like you were right about that.
When I stop CKB by Ctrl+Z in terminal, this exception will appear. The info displayed on the terminal shows that the CKB has been stopped, but the CKB process continues. Is this an approach we don't support by Neuron?

image

@yanguoyu

Copy link
Copy Markdown
Contributor Author

approach

Maybe you should try to use Ctrl + C to kill the ckb node process.

@Keith-CY
Keith-CY merged commit b6889d9 into nervosnetwork:develop Aug 30, 2022
@yanguoyu
yanguoyu deleted the fix-empty-ckb-path branch August 30, 2022 02:59
@Keith-CY Keith-CY mentioned this pull request Sep 2, 2022
@Keith-CY Keith-CY mentioned this pull request Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants