Skip to content

fix: New instance for every test case to avoid side effect #2488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yanguoyu merged 9 commits into from
Sep 19, 2022
Merged

fix: New instance for every test case to avoid side effect #2488

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
350e91e
fix: New instance for every test case to avoid side effect
yanguoyu Sep 18, 2022
9ceb8b3
fix: Add monitor name for test case
yanguoyu Sep 18, 2022
e325bae
fix: Add logs for test case
yanguoyu Sep 18, 2022
a86e664
fix: Move reset to inner beforeEach
yanguoyu Sep 18, 2022
97f7b97
fix: move console
yanguoyu Sep 18, 2022
d181a2d
fix: Fix test case
yanguoyu Sep 18, 2022
3f99319
fix: Fix test case
yanguoyu Sep 18, 2022
fb2d38f
fix: Wait test case execute.
yanguoyu Sep 18, 2022
8b40161
fix: Fix test case
yanguoyu Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions packages/neuron-wallet/tests/services/monitor.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,10 @@ function wait(times: number) {
})
}
describe('base monitor', () => {
const monitor = new MonitorTest()
let monitor: MonitorTest

beforeEach(() => {
monitor = new MonitorTest()
isLivingMock.mockReset()
restartMock.mockReset()
})
Expand All @@ -126,25 +127,29 @@ describe('base monitor', () => {
})
it('isLiving timeout', async () => {
isLivingMock.mockImplementation(() => wait(200))
await monitor.startMonitor(100)
await wait(200)
await monitor.startMonitor(200)
await wait(300)
await monitor.stopMonitor()
await wait(400)
expect(isLivingMock).toHaveBeenCalled()
expect(restartMock).toHaveBeenCalledTimes(1)
})
it('not living wait restart', async () => {
isLivingMock.mockResolvedValue(true).mockResolvedValueOnce(false)
restartMock.mockImplementation(() => wait(400))
isLivingMock.mockResolvedValue(false)
restartMock.mockImplementation(() => wait(1000))
monitor.name = 'not living wait restart'
await monitor.startMonitor(100)
await wait(800)
await wait(400)
await monitor.stopMonitor()
await wait(400)
expect(isLivingMock).toHaveBeenCalled()
expect(restartMock).toHaveBeenCalledTimes(1)
})
it('start monitor with first', async () => {
isLivingMock.mockResolvedValue(true).mockResolvedValueOnce(false)
await monitor.startMonitor(1000, true)
await wait(500)
expect(isLivingMock).toHaveBeenCalled()
expect(restartMock).toHaveBeenCalled()
isLivingMock.mockResolvedValue(false)
await monitor.startMonitor(10000, true)
expect(isLivingMock).toHaveBeenCalledTimes(1)
expect(restartMock).toHaveBeenCalledTimes(1)
})
it('twice start monitor', async () => {
isLivingMock.mockReset()
Expand Down